! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[MailWatcher]: icon keeps the red-road-sign after connection is back
Status:
RESOLVED: MOVED
Severity:
trivial
Product:
Xfce4-mailwatch-plugin
Component:
General

Comments

Description emitrax 2008-12-28 12:45:19 CET
It's a stupid thing really, but I find it annoying.

When I check for updates and I have no connection the little red-road-sign comes up in the icon (which is gray), but when I update again with connection, the icon change color like expected if I have new emails, but the little red-road-sign doesn't disappear like I expect.
Comment 1 Samuli Suominen 2009-09-04 06:49:59 CEST
http://bugs.gentoo.org/show_bug.cgi?id=272953
Comment 2 robuck 2009-10-19 01:59:07 CEST
I also find this bug annoying. I hope it gets fixed. It seems like a minor thing to change, but I couldn't do it myself.
Comment 3 Brian J. Tarricone (not reading bugmail) 2009-10-19 02:06:13 CEST
Please don't spam with "me too" messages.

It's not at all easy to fix, otherwise I would've done it already.
Comment 4 Brian J. Tarricone (not reading bugmail) 2009-11-21 22:32:48 CET
*** Bug 6012 has been marked as a duplicate of this bug. ***
Comment 5 Brian J. Tarricone (not reading bugmail) 2010-01-14 02:21:10 CET
*** Bug 6155 has been marked as a duplicate of this bug. ***
Comment 6 aky 2010-03-25 01:33:21 CET
actually i find it very easy to get rid of the 'red-road-sign' in mailwatcher's panel icon; depending on what you want you need.. either:
1) uncheck the 'Show log status in icon' checkmark from mailchecker's Properties/View Log window and the 'red-road-sign' won't show any longer on errors
or,
2) if you'd still like to get feedback on netowrk and/or mailserver issues just leave that checked and when the 'red-road-sign' shows open the same afore mentioned log window (Properties/View Log) and the 'red-road-sign' will poof
Comment 7 Corentin Perard 2011-01-09 17:01:32 CET
*** Bug 7072 has been marked as a duplicate of this bug. ***
Comment 8 Ján Sučan editbugs 2013-12-04 23:53:57 CET
*** Bug 7697 has been marked as a duplicate of this bug. ***
Comment 9 Ján Sučan editbugs 2013-12-05 00:18:04 CET
*** Bug 10369 has been marked as a duplicate of this bug. ***
Comment 10 Ján Sučan editbugs 2013-12-05 00:39:11 CET
*** Bug 9093 has been marked as a duplicate of this bug. ***
Comment 11 Ján Sučan editbugs 2013-12-05 15:19:10 CET
*** Bug 9832 has been marked as a duplicate of this bug. ***
Comment 12 Ján Sučan editbugs 2013-12-05 15:24:27 CET
*** Bug 10065 has been marked as a duplicate of this bug. ***
Comment 13 Ján Sučan editbugs 2013-12-12 19:42:25 CET
Error/warning indicating is universal mechanism and network connection is not the only reason why the indicator icon is showed. This icon stays showed until the user views the log because errors/warning is something that user should be interested in. If he is not interested he can disable indicating in View Log window.

In one of the duplicate reports someone said that internet connection should be checked before indicating error. As far as I know there is not platform independent way how to check if network connection is available. And if it was we should have to know if network is not available because user wants it to be so or not (i.e. if he knows about it or not).

I think the easiest solution is to introduce two configurable threshold values. First for number of subsequent checks in which error/warning occurs and after which the indicator icon is displayed. Second for the number of subsequent checks in which no error/warning occurs and after which the pending error/warning event is cleared and indicator icon is hidden.

If someone has some objections let me know.
Comment 14 Mihail L 2013-12-13 15:24:47 CET
I think that applet error indication should just say: "I do/don't know current state of all your mail boxes". So, if last check of all mail boxes was successful, error indication may be turned off. This is the way many monitoring systems work.
Comment 15 Ján Sučan editbugs 2013-12-13 16:25:41 CET
Mihail, thanks for the reply. Yes, it seems that hiding error icon after the first successful check would be sufficient.

But now I have realized that mailwatch plugin design imply that there is nothing as "check of all mailboxes" (all in the same time). Each mailbox has its own thread and is checked independently from others. Then we can say that error indication icon may be hidden after the last check from the sequence of successful checks of all mailboxes starting with the first mailbox. If I implement it like that, it would mean that if user has two mailboxes, one with checking interval 2 minutes and one with the 60 minute interval, in the worst case it will take almost 58 minutes (and 28 successful checks of 2-minute mailbox) until error icon disappears.

The better solution would be a "distributed" version of this mechanism. Error/warning should be cleared only by the next successful check of the mailbox which caused it. The error icon would be hidden only if there is no mailbox with error status and showed otherwise.
Comment 16 Mihail L 2013-12-13 16:51:14 CET
Yes, that would be great! For example, after every mail check in a thread we could set mail box' "local status" and then check all those "local statuses" to see if any mail box is under error condition.
Comment 17 Michael Kogan 2013-12-13 17:33:55 CET
Thumbs up for this solution!
Comment 18 Ján Sučan editbugs 2013-12-13 18:36:35 CET
It will take some time while I get used to the implementation of logging functionality of the plugin (as a new maintainer) to be able to write patch of satisfactory quality. But I think that it will soon be in the master branch of the source tree and this bug closed once and for all.
Comment 19 Ján Sučan editbugs 2013-12-27 17:08:38 CET
After hours of source code reviewing I have realized that I don't know how to implement the fix without ugly hacks (and I don't have a time and motivation for a major redesign of the plugin). So this bug could be fixed if someone will provide a clean solution or some other maintainer will push some fix to the git repository.
Comment 20 Git Bot editbugs 2020-05-24 00:40:21 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/panel-plugins/xfce4-mailwatch-plugin/-/issues/8.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #4747

Reported by:
emitrax
Reported on: 2008-12-28
Last modified on: 2020-05-24
Duplicates (8):
  • 6012 mailwatch panel icon never recovers from lost network connectivity
  • 6155 Error icon doesn't disappear
  • 7072 'forbidden' icon stays when there wasn't any network connectivity at runtime
  • 7697 Can't get rid of error icon even when server is available again
  • 9093 "Show log status in icon" shows last state forever
  • 9832 Icon change when no internet connection
  • 10065 Error indicator should not appear when network is down
  • 10369 internet connectivity button doesn't reset

People

Assignee:
Ján Sučan
CC List:
13 users

Version

Version:
1.1.0 or older

Attachments

Additional information