! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Terminal resizes incorrectly with multiple tab open/closures
Status:
RESOLVED: FIXED
Priority:
Very High
Severity:
blocker
Product:
Xfce4-terminal
Component:
General

Comments

Description s0ulslack 2008-12-18 17:39:37 CET
When opening and then closing a tab, Terminal is resized but isn't done correctly.  You end up with a smaller window then original, after opening/closing several tabs you need to resize the window because it gets too small.  I didn't see the version I'm using listed, but its 0.2.9svn-28991.
Comment 1 Jannis Pohlmann editbugs 2008-12-18 17:46:25 CET
I cannot reproduce it here (version 0.2.9svn-28782).
Comment 2 Nick Schermer editbugs 2008-12-19 07:03:27 CET
There is a race in the code. It's hard to reproduce but sometimes it happens.
Comment 3 Oliver Jeeves 2009-05-08 09:19:24 CEST
I get this problem when I have a transparent background on my terminal windows.

Currently, I have compositing and transparent backgrounds turned off, and the problem isn't occurring, or is rare enough that I'm not seeing it.

With transparent backgrounds, windows resize incorrectly more times than not. Re-drawing/re-sizing windows is quite slow when I have transparent backgrounds on, so I guess it's this that's exacerbating the race condition.

What it appears is happening (and I write this with no real understanding of what's going on) is that it's a race between the terminal to resize the window such that inner dimensions of the text area are the same, and the window manager to resize the window based on the new size constraints to be a similar 'outer' size to what it was before.
Comment 4 reisio 2009-05-13 03:29:49 CEST
Created attachment 2349 
manifestation

Not only does the window get slightly resized, it gets completely confused about the COLSxROWS.

I get this bug reliably, no compositing/transparency, Terminal 0.2.12, Xfce 4.6.1.
Comment 5 reisio 2009-05-13 03:50:58 CEST
I seem to only be able to get it to happen by closing the first (left-most) tab.
Comment 6 Nick Schermer editbugs 2009-07-02 17:14:59 CEST
This should not happen in trunk anymore (well I cannot reproduce it anymore). It was a weird race between size updates. Could someone test this in trunk too?
Comment 7 s0ulslack 2009-07-04 19:05:05 CEST
Still there in r30194 for me, it also doesn't seem to matter if its the first or second tab that I close.

I don't see the race condition when my box is at 100% load, things open/close as expected.  btw, great work on the Terminal updates lately!
Comment 8 Nick Schermer editbugs 2009-07-06 19:09:49 CEST
Tried to fix this in the code but I can't. When I switch to the metacity window manager the problem disappeard, so maybe it's a race in xfwm4 with the geometry hints we use? Olivier? Any ideas?
Comment 9 Nick Schermer editbugs 2009-07-07 09:25:43 CEST
Red title in search results please....
Comment 10 Olivier Fourdan editbugs 2009-07-08 20:31:48 CEST
(In reply to comment #8)
> Tried to fix this in the code but I can't. When I switch to the metacity window
> manager the problem disappeard, so maybe it's a race in xfwm4 with the geometry
> hints we use? Olivier? Any ideas?

The WM does not set the size hints, it reads it. So if the hints are wrong (with xprop), it cannot be the WM fault.
Comment 11 reisio 2009-08-10 15:10:15 CEST
This seems to be resolved for me with version 0.4.
Comment 12 Connor Behan 2011-06-09 01:13:15 CEST
The shrinking of the window's height (on my system) is definitely still there in 0.4.7. The confusion between rows and columns is a bug I've seen too but it isn't caused by closing tabs. It's caused by resizing the terminal after output has already been printed to it. If I want a bigger terminal it only works if I resize the window immediately after I open it.
Comment 13 Olivier Fourdan editbugs 2011-06-09 09:32:47 CEST
methink it's a discrepancy in the size increments, xfwm4 will enforce the window size to match the size increments provided by the application, thus downsizing the window slightly to the closest multiple of the size increments.

kwin does the same as xfwm4, but metacity is a lot less strict about it last time I checked.
Comment 14 Robert 2011-09-04 16:45:43 CEST
The terminal resizes and goes off the bottom edge of the screen when not maximized.

To reproduce, place a terminal at bottom of the screen and open a second tab.

I would expect the window to not be resized as this would solve the problem. An alternative would be to have an option to display tabs when only one tab is open, although this would waste space on the monitor.
Comment 15 Olivier Fourdan editbugs 2011-09-09 14:14:48 CEST
(In reply to comment #14)
> The terminal resizes and goes off the bottom edge of the screen when not
> maximized.
> 
> To reproduce, place a terminal at bottom of the screen and open a second tab.
> 
> I would expect the window to not be resized as this would solve the problem. An
> alternative would be to have an option to display tabs when only one tab is
> open, although this would waste space on the monitor.

Please do not hijack this bug, this is a different issue fixed with git commit cee208fd and 798d9cd4
Comment 16 Olivier Fourdan editbugs 2011-09-09 14:20:41 CEST
This particular bug has to do with size increments, I suspect it should be fixed with git commit bf911e27

The problem I suspect is a discrepancy with the size increments, that xfwm4 would try to fix by resizing the window so that the size actually match the size increment, thus inducing a race condition with Terminal.

GNOME Terminal in gnome3 is broken the same, and the result is a loop of events which shrink the window automatically.

git commit bf911e27 makes xfwm4 a lot more relax and ignore the size increment when receiving a configure request (ie honor what the apps asks for even if it goes against the size increment).

Please try current git and report back.
Comment 17 Massimo Burcheri 2012-05-07 09:48:02 CEST
I would even prefer not resizing at all when tabs come into play. Or at least allow a setting "Always show tabs". Maybe this is worth a separate request..
Comment 18 Nick Schermer editbugs 2012-12-24 21:01:31 CET
Pushed a new fix for this.
Comment 19 Jak Wings 2013-04-21 02:58:35 CEST
(In reply to comment #18)
> Pushed a new fix for this.

Just as comment #4 said, I've this problem, too.

OS: Gentoo x86_64
Program: terminal 0.4.8 (Xfce 4.10)

With: xfwm4 version 4.10.0 (revision cc70567) Compiled against GTK+-2.24.16, using GTK+-2.24.16.
Comment 20 Jak Wings 2013-04-21 03:00:06 CEST
(In reply to comment #19)
> (In reply to comment #18)
> > Pushed a new fix for this.
> 
> Just as comment #4 said, I've this problem, too.
> 
> OS: Gentoo x86_64
> Program: terminal 0.4.8 (Xfce 4.10)
> 
> With: xfwm4 version 4.10.0 (revision cc70567) Compiled against GTK+-2.24.16,
> using GTK+-2.24.16.

Oh no, should refer to comment #3

Bug #4728

Reported by:
s0ulslack
Reported on: 2008-12-18
Last modified on: 2013-04-21

People

Assignee:
Nick Schermer
CC List:
8 users

Version

Version:
unspecified

Attachments

manifestation (21.77 KB, image/gif)
2009-05-13 03:29 CEST , reisio
no flags

Additional information