Here's the stuff for the panel plugin. Only xfce-volume-button.c didn't seem to need any changes; the others have the usual improvements per the strings style guidelines.
Created attachment 2027 xfce-mixer-plugin.c.patch
Created attachment 2028 xfce-plugin-dialog.c.patch
Created attachment 2029 xfce-mixer.c.patch More stuff for xfce4-mixer.
Created attachment 2030 xfce-mixer-controls-dialog.c.patch
Created attachment 2031 xfce-mixer-window.c.patch
I went through the libxfce4mixer files; nothing to be done for anything there. It didn't have any strings that needed changin'.
What is the rationale behind removing "Please" from all strings?
Shortening the strings, which the style guide says is good. No real need for 'em. It's not impolite to leave them out; it may even be too polite to leave them in. It's better to get straight to the point when asking the user for action. :) Lemme ask you this -- why preface every request string with "please"? Why leave it *in*?
In general I don't object to prefixing requests with "please" when it's in a dialog box where it's unavoidable to directly address the user, but I'd leave it out in most places, especially in an XfceTitledDialog subtitle. The subtitle should *not* be used as a replacement for proper dialog text. It should provide a short and to-the-point expository description of what the dialog is for. To put it another way, you shouldn't be using the subtitle to ask the user to do something. (I'd say the usage in xfce-mixer-controls-dialog.c is wrong, though I woudn't say that definitively as I haven't looked at the actual dialog.) (Josh: as a note for future work, it's easier on us if you just create one patch file with all of the changes, instead of one patch per source file.)
(In reply to comment #8) > Shortening the strings, which the style guide says is good. No real need for > 'em. It's not impolite to leave them out; it may even be too polite to leave > them in. > > It's better to get straight to the point when asking the user for action. :) Right. > Lemme ask you this -- why preface every request string with "please"? Why leave > it *in*? I thought it would be more polite and friendly. But if you say it isn't necessarily needed, I'm fine with removing the "please". In fact, I've just committed your patches (the one for xfce-mixer-plugin.c with one modification) to SVN (revision 29004).