! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
libexo automagically depends on libwww (libmd5)
Status:
RESOLVED: FIXED
Priority:
Medium
Severity:
normal
Product:
Exo
Component:
General

Comments

Description Christoph Mende 2008-11-10 17:25:09 CET 
from configure.in.in line 124:
AC_SEARCH_LIBS([MD5Init], [md md5 c], \
               [AC_DEFINE([HAVE_MD5INIT], [1], [Define if MD5Init present])])

this should either be a mandatory dependency or controlled via --enable/--disable, see http://www.gentoo.org/proj/en/qa/automagic.xml
Comment 1 Benedikt Meurer editbugs 2008-11-10 17:59:57 CET 
This dependency should be removed all together and we should stick to the internal MD5 code. Maybe Jannis can have a look at this.
Comment 2 Jannis Pohlmann editbugs 2008-11-10 18:19:55 CET 
Created attachment 1963 
Patch to use internal MD5 code

@Benny: Like this?
Comment 3 Jannis Pohlmann editbugs 2008-11-10 18:24:40 CET 
Actually ... if the patch is ok, I'll just remove my name from the source file before applying it. I expected more changes to be necessary (which might have justified that copyright notice).
Comment 4 Benedikt Meurer editbugs 2008-11-10 19:06:08 CET 
Jap.
Comment 5 Jannis Pohlmann editbugs 2008-11-10 19:22:46 CET 
Author: jannis
Date: 2008-11-10 19:19:08 +0000 (Mon, 10 Nov 2008)
New Revision: 28714

Modified:
   libexo/trunk/ChangeLog
   libexo/trunk/configure.in.in
   libexo/trunk/exo/exo-icon-view.c
   libexo/trunk/exo/exo-md5.c
Log:
	* configure.in.in, exo/exo-md5.c: Get rid of external MD5 functions.
Comment 6 Jannis Pohlmann editbugs 2008-11-10 19:23:25 CET 
Note that the icon view accidently slipped into the commit. It has already been reverted (but the md5 changes remain committed of course).

Bug #4595

Reported by:
Christoph Mende
Reported on: 2008-11-10
Last modified on: 2009-10-09

People

Assignee:
Nick Schermer
CC List:
1 user

Version

Version:
unspecified
Target Milestone:
Exo 0.3

Attachments

Patch to use internal MD5 code (3.29 KB, patch)
2008-11-10 18:19 CET , Jannis Pohlmann 		no flags

Additional information