! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfce4-settings fails to set workspace names
Status:
RESOLVED: FIXED
Product:
Xfce4-settings
Component:
Settings Helper

Comments

Description Olivier Fourdan editbugs 2008-11-07 19:33:00 CET
xfce4-settings does not set the workspaces names properly.

To reproduce:
1) Open the workspace settings dialog
2) Set names for all workspaces
3) Log out/login again

Observed result:

The workspaces names are not set, or partly set (some names are set, some other aren't).

Expected result:

The workspaces names are set correctly
Comment 1 Brian J. Tarricone (not reading bugmail) 2008-11-07 19:53:16 CET
Yeah, it's pretty broken.  Haven't had time to look into it yet.
Comment 2 Olivier Fourdan editbugs 2008-11-08 10:47:34 CET
That's weird, adding traces show that the names should be set. Still the property is not changed:

xfce_workspaces_helper_init: Setting workspace 0 name "bbbbb"
xfce_workspaces_helper_init: Setting workspace 1 name "aaaa"
xfce_workspaces_helper_init: Setting workspace 2 name "Email"
xfce_workspaces_helper_init: Setting workspace 3 name "Web"

_NET_DESKTOP_NAMES(UTF8_STRING) = 0x57, 0x6f, 0x72, 0x6b, 0x73, 0x70, 0x61, 0x63, 0x65, 0x20, 0x31, 0x0, 0x57, 0x6f, 0x72, 0x6b, 0x73, 0x70, 0x61, 0x63, 0x65, 0x20, 0x32, 0x0, 0x57, 0x6f, 0x72, 0x6b, 0x73, 0x70, 0x61, 0x63, 0x65, 0x20, 0x33, 0x0, 0x57, 0x65, 0x62, 0x0

Weird, heh... Only the last one is properly set.
Comment 3 Brian J. Tarricone (not reading bugmail) 2008-11-11 05:15:22 CET
Should be fixed in svn now.
Comment 4 Olivier Fourdan editbugs 2008-11-11 13:04:50 CET
Created attachment 1965 
Use GdkScreen and derive WnckScreen instead of the other way around

Unfortunatelky, the fix does not build with older version of libwnck which are lacking wnck-screen-get()

The proposed patch attached here works the other way arround, it used a GdkScreen and gets the WnckScreen from it.

Just like current code, the initial screen is the default sccreen, but this approach is still compatible with a future multi-screen version (at least, as much as the current code is).
Comment 5 Olivier Fourdan editbugs 2008-11-11 13:06:09 CET
Reopening bug as the fix does not build on older libwnck. 
What would you think of the approach described above in the patch?
Comment 6 Brian J. Tarricone (not reading bugmail) 2008-11-11 20:05:33 CET
Should be fixed now.

Bug #4588

Reported by:
Olivier Fourdan
Reported on: 2008-11-07
Last modified on: 2009-07-14

People

Assignee:
Stephan Arts
CC List:
2 users

Version

Attachments

Additional information