Hi, i've recently have played with libcanberra, and it looks like it brings neat earcandy for gtk apps, which xfce is. I can hear sounds which are played on every actionlike minimize window etc, also it wasn't hard to add a "welcome" playing sound after you login. Hardest part is to add shutdown/logout/swicth sound event. Anyways it would be nice to see some support for xfce side for libcanberra, maybe some little configuration tool, as probably there are people who do not need all the sound effects ;)
So, this is a little more urgent than it may seem. In Fedora 10, if one installs any of Gnome on the system (including gdm, which has libcanberra as a hard dep), one gets libcanberra. This results in every window open or close making a horrible whooshing noise, and there's NO WAY to disable it short of hacking systemwide scripts that aren't really meant to be edited. See: http://www.archivum.info/fedora-devel-list@redhat.com/2008-08/msg00608.html
That's *not* the good way. Sound effects should be opt-in, not opt-out. If the Xsettings is not present, assume no sound.
This should probably get moved to xfconf? See http://www.archivum.info/fedora-devel-list@redhat.com/2008-08/msg00653.html Thanks.
re comment #2: Yes, I think so too, but just repeating what I'm told. I'll file a bug with Fedora about that too.
If it's a new XSettings I guess we can add this to xfce 4.6 (but that has to be done before feature freeze in a couple of days), but cannot make such addition to the stable 4.4 tree. I doubt F10 will ship with xfce 4.6 so for F10, vendor patching will be required, at best.
Moving to 4.6 (at best)
Too late for Fedora 10 too, really. Unfortunate, but there we are. If it gets fixed eventually I'll be happy, though. I filed a Fedora bug at: https://bugzilla.redhat.com/show_bug.cgi?id=466279
This is trivial -- just need to add the applicable xsettings to the list in xfsettingsd, and set the defaults to shut it off. Stephan can do it quickest ^_^.
(Oh, just noticed the first comment. Sorry to hijack the bug. In the future, please open separate bugs for things that aren't really related.)
(In reply to comment #9) > (Oh, just noticed the first comment. Sorry to hijack the bug. In the future, > please open separate bugs for things that aren't really related.) I can do it if nobody else wants, I'd also like to add an optional new tab (defaults to disabled) to the appareance settings to give gui options to the corresponding settings. Adding a new settings dialog for 3 options (for the moment, I am not talking about selecting sound themes or anything) would be a bit overkill. Opinions?
Reading the code, Stephan already put the entries, so there is nothing to do in 4.6: http://svn.xfce.org/index.cgi/xfce/diff/xfce4-settings/trunk/xfsettingsd/registry.c?rev1=27896;rev2=27897
Agreed, a new settings dialog for this is overkill. Not sure "Appearance" makes the most sense, but I can't think of anything better, so... Hehe, I guess it would've made more sense if it was still called "UI Settings" ^_~.
UI options added to appareance dialog, in "Settings" tab. Disabled by default, build with --enable-sound-settings to enable the options.
Now, we'd need someone willing to test...
Why disabled by default? I feel like we're gonna get lots of "I've suddenly started getting sounds on my desktop and there's no way to turn them off" questions all over. Ideally, packagers will know whether or not to enable for their particular use case, but it's just one more random non-obvious thing they need to know about...
(In reply to comment #15) > Why disabled by default? Ideally, we should display or hide the controls depending on the availability of Camberra, but I am not sure there is a way to tell simply if Camberra is available and functional, with gtk+ supports and all. So if we enable the controls by default, we shall end up with a number of users who will activate the options and then complain that it does nothing because ttheir sdistro has no libcamberra support (This is just an XSettings, we don't really know what is really there on the system). > I feel like we're gonna get lots of "I've suddenly > started getting sounds on my desktop and there's no way to turn them off" > questions all over. Ideally, packagers will know whether or not to enable for > their particular use case, but it's just one more random non-obvious thing they > need to know about... Is it better to have reports of "I activate the sounds on my RHEL / Fedora < 10 /Ubuntu < 0810 and nothing happen"? But I agree it should be documented in the INSTALL file and/or in the README.
Anyway, distros should not be as dumb and shouldn't load canberra support at gdm time. In Debian, gtk/gnome maintainers told me that, when they'll look at it, they'll manage to have it loaded by gnome-session which I guess is the “right thing to do”. (that, or gnome-settings-daemon). So in this case, no problem in Xfce if the Xsettings are disabled by default. It's just a workaround anyway, for distro doing bad stuff, until everything settle down. In the generic case, I guess “we” should wait for having “complete” canberra support in Xfce, so one could chose to explicitely load it with Xfce, change the theme etc.
(In reply to comment #15) > Why disabled by default? I feel like we're gonna get lots of "I've suddenly > started getting sounds on my desktop and there's no way to turn them off" > questions all over. Ideally, packagers will know whether or not to enable for > their particular use case, but it's just one more random non-obvious thing they > need to know about... ehm... When xfsettingsd (post-pinkie) is running it IS disabled by default ^_^.
(In reply to comment #18) > When xfsettingsd (post-pinkie) is running it IS disabled by default ^_^. No, well, yes, but that's two different things! ;-) 1) The UI optionsa re disabled by default, ie they don't show unless specified when building (that was Brian's concern) 2) The settings are of by default (this is what you are talking about, but that's fine with me, we just have to have defaults anyway)
Tested, it works with patch for xfsettings committed in rev. 28129.
(In reply to comment #20) > Tested, it works with patch for xfsettings committed in rev. 28129. I'd rather keep it with Int values... gtk/x11 guys have a tendency to add a '-1' value for a 'let the universe work it out' kind of behaviour. The m/l and gnome's impl suggest Integers to be used, unless we don't want to support '-1' regardless of the possibility that someone adds it... I'd rather stick to Ints instead of booleans.
(In reply to comment #21) > (In reply to comment #20) > > Tested, it works with patch for xfsettings committed in rev. 28129. > > I'd rather keep it with Int values... gtk/x11 guys have a tendency to add a > '-1' value for a 'let the universe work it out' kind of behaviour. > > The m/l and gnome's impl suggest Integers to be used, unless we don't want to > support '-1' regardless of the possibility that someone adds it... I'd rather > stick to Ints instead of booleans. Humm, no, the semantic is really a boolean, ie sound events are enable or not, I do not see what int would provide. Plus, I checked gconf scheme and those are treated as boolean in gconf type too.
(In reply to comment #22) > (In reply to comment #21) > > (In reply to comment #20) > > > Tested, it works with patch for xfsettings committed in rev. 28129. > > > > I'd rather keep it with Int values... gtk/x11 guys have a tendency to add a > > '-1' value for a 'let the universe work it out' kind of behaviour. > > > > The m/l and gnome's impl suggest Integers to be used, unless we don't want to > > support '-1' regardless of the possibility that someone adds it... I'd rather > > stick to Ints instead of booleans. > > Humm, no, the semantic is really a boolean, ie sound events are enable or not, > I do not see what int would provide. Plus, I checked gconf scheme and those are > treated as boolean in gconf type too. Ok, fair enough.
Thanks for adding a support for this. Anyways there is a problem how to play logout sound on logout/restart ?
(In reply to comment #24) > Thanks for adding a support for this. > > Anyways there is a problem how to play logout sound on logout/restart ? Yes, for that to work, xfce4-session needs support for libcanberra... Since we are at a feature-freeze for 4.6, that won't be added now. I am closing this bug since the related XSETTINGS have been added now. You need to submit separate bugreports for libcanberra support in xfce4-session and xfwm4 (targeted at 4.8)