Now we have a settings daemon, if would be nice to add a clipboard manager in it so clipboard content is stored when an application closes. There are implementations in gnome and moblin we can use: http://moblin.org/repos/?p=projects/moblin-applets.git;a=tree http://svn.gnome.org/viewvc/gnome-settings-daemon/trunk/plugins/clipboard/ No dialog or so, maybe a channel with 1 setting to enable/disable to backend.
Cool, sounds like a good idea. Perhaps we should wait for beta1 or beta2, though. There are enough things that need fixing for alpha; I don't want too much more new untested code for alpha if we can help it.
Yeah i'll look into it and wait for the commit after pinky is released.
For the record, I copied that daemon into clipman. Currently it does the job correctly except for one bug (bug 5738), the clipboard selection is lost when copying text from firefox/thunderbird also google chrome. When this goes into xfce-settings there should not be any enable/disable setting. The daemon should start by checking if the atom CLIPBOARD_MANAGER is free. Also the daemon will stop when someone else makes a request to take over the atom.
Created attachment 2675 Patch to add a clipboard daemon Here is a patch which adds a clipboard manager daemon based on xfce4-clipman-plugin code. I simply copied Mike's code for the gobject and started the daemon when launching xfce4settings-helper. If there is already a clipboard manager running, the daemon will not start.
So this was in master for a couple of minutes, but people had code issues. So the following changes as discussed no irc: - XfceClipboardManager object name. - Use indent style we use in xfce4-settings (same as thunar fyi). - Start all function with xfce_clipboard_manager, easier for debugging. - Don't use a singleton, no use here. - Drop the {g,s}et_property functions. - Don't see any use for the idle to start the daemon.
(In reply to comment #5) > So this was in master for a couple of minutes, but people had code issues. So > the following changes as discussed no irc: > > - XfceClipboardManager object name. > - Use indent style we use in xfce4-settings (same as thunar fyi). > - Start all function with xfce_clipboard_manager, easier for debugging. > - Don't use a singleton, no use here. > - Drop the {g,s}et_property functions. > - Don't see any use for the idle to start the daemon. I wouldn't bother, it will just make it a bit annoying to sync it with GNOME (even if there isn't any real reason it should change much). But who knows.
The code in Gnome is still using X directly right? So what is there so sync.
Ok, I believe my branch is ready to be reviewed. I addressed all the points listed above. I just have one doubt, I wonder if the clipboard manager should be unrefed in xfce4-settings-helper code.
I was wrong about the thunar code style, sorry for that. Also fixed some other issues and pushed it to your branch. Please test of the manager selection still works with the clipboard plugin.
Branched merged to master and released in 4.7.0.