! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
bashism in xdg-commit
Status:
RESOLVED: FIXED
Priority:
Medium
Severity:
minor
Product:
Xfce4-dev-tools
Component:
General

Comments

Description Yves-Alexis Perez editbugs 2008-06-20 06:16:30 CEST 
Hi,

xdt-commit is a /bin/sh, but it contains a bashism:

94: COMMIT_MSG=$(echo "$COMMIT_MSG" $'\n' "$MSG")

the $'\n' stuff is a bashism, which can be replace by $(printf '\n')

There may be other way to do this cleanly too :)

Cheers,
Comment 1 Yves-Alexis Perez editbugs 2008-06-20 06:44:10 CEST 
Created attachment 1699 
Fix bashisms in xdt-commit

The patch should fix bashisms in xdt-commit.

Another simple way would be to s/sh/bash in the first line :)

Cheers,
Comment 2 Skunnyk 2010-11-09 22:09:08 CET 
Hi,

xdt-commit now uses "#!/bin/bash" since http://git.xfce.org/xfce/xfce4-dev-tools/commit/?id=992f334faf49883293848a300e017d0c3bea6f13. 
I think this bug can be closed ?
Comment 3 Jannis Pohlmann editbugs 2010-11-09 22:15:30 CET 
Yes.

Bug #4163

Reported by:
Yves-Alexis Perez
Reported on: 2008-06-20
Last modified on: 2010-11-09

People

Assignee:
Jannis Pohlmann
CC List:
1 user

Version

Version:
4.4.x
Target Milestone:
Xfce 4.4

Attachments

Fix bashisms in xdt-commit (1.33 KB, patch)
2008-06-20 06:44 CEST , Yves-Alexis Perez 		no flags

Additional information