<Corsac> ongardie: maybe it'd be nice to have the possibility to eject devices from the places plugin? <Corsac> (instead of only umounting) <ongardie> uh...you should be able to <ongardie> i ejected a dvd last night <ongardie> does thunar let you? <Corsac> yes <ongardie> and this is with v1.1? <Corsac> yes
Created attachment 1663 Use this to get better debugging output Yves-Alexis: Please apply this patch, compile places with debugging output, watch it by running your panel from the console, and paste how the volume is identified by thunar-vfs as a comment to this bug.
<Corsac> ongardie: I remember thunar needed a patch to eject other stuff than dvds <Corsac> maybe places needs it too? <Corsac> eject appears correctly for optical stuff, but not for usb storage <ongardie> Corsac: "needed a patch"? a debian-specific patch? because places uses the *same* criteria as thunar (upstream) <ongardie> specifically, the eject option is inside a if (thunar_vfs_volume_is_disc(...)) <ongardie> s/a/an/ <Corsac> ongardie: http://bugzilla.xfce.org/show_bug.cgi?id=3119 <ongardie> why didn't benny write the fookin' svn revision? <ongardie> ah, here's the relevant follow-up to that bug: http://svn.xfce.org/index.cgi/xfce/revision/?rev=26457 <ongardie> only 8 months later :) <ongardie> Corsac: does the thunar you're testing with include r26457? <Corsac> http://svn.debian.org/wsvn/pkg-xfce/desktop/trunk/thunar/debian/patches/03_use-eject-where-necessary.patch?op=file&rev=0&sc=0 <Corsac> so eys <Corsac> yes <ongardie> how is places supposed to behave then? do i make it work like debian's patches and the next thunar release, or do i keep it consistent with stable thunar? <ongardie> the right thing would be to add an ( #if the thunar version is ..., behave like this, else like that ) <ongardie> and then debian can keep another local patch that turns it into an ( #if 1 ), i guess <Corsac> I dont think it's too bad to have places behaves "nicer" than thunar stable <ongardie> the intent is consistency. (and for this particular issue, i prefer the old behavior) <Corsac> the old behavior is just wrong :/ <Corsac> well, it's not safe <ongardie> Corsac: what do you mean it's not safe? <Corsac> ongardie: when you dont "eject" an usb device, it's not powered off <Corsac> and some of them require this <Corsac> (like ipods and stuff like that) <ongardie> if you unmount them, it's fine, right? <Corsac> no <ongardie> why not? <Corsac> because the "eject" instruction is more than umount <Corsac> umount just umount the fs <Corsac> while eject tell the device to stop <Corsac> in fact, it'd be nice to have "umount" for fs and "eject" for device <Corsac> but currently the device isn't displayed at all <ongardie> i fail to see the difference from the device's perspective <Corsac> check google <Corsac> i'm off for now <ongardie> if i plug my ipod shuffle (first gen) into a USB adapter into a wall socket, nothing tells it to eject <colinl> ongardie: try to unmount your ipod instead of ejecting it: it'll keep its Do Not Disconnect message on it screen <ongardie> colinl: ipod shuffle - no screen, but that helps me understand why Corsac cares
Now that you've made a lenny backport of Thunar 1.0.1, I gave in :) Committed in svn r7872.