! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Compilation error without libnotify
Status:
CLOSED: FIXED

Comments

Description Enrico Tröger editbugs 2007-12-02 08:57:26 CET
Current SVN version(r26411) of orage fails to compile if libnotify isn't installed on the system. Attached is a very simple patch to fix compilation.
Comment 1 Enrico Tröger editbugs 2007-12-02 08:58:12 CET
Created attachment 1449 
Simple patch to fix the compilation error.
Comment 2 juha editbugs 2007-12-02 22:57:12 CET
It should not cause the compilation to fail, if there is a non used function
defined.
Anyway, it is really not needed, so fixed in svn revision 26430.
Comment 3 Enrico Tröger editbugs 2007-12-03 14:56:30 CET
It failed to compile because "NotifyNotification" in the argument list isn't declared when libnotify headers are not available and so the compiler refuses to compile, regardless the function is actually used or not.

Now it compiles again and all is fine. By the way, do you compile the code with -Wall? If I do this, I get tons of warnings about "unused variables". Of course, not important and not dangerous but still ugly.

Bug #3711

Reported by:
Enrico Tröger
Reported on: 2007-12-02
Last modified on: 2007-12-03

People

CC List:
0 users

Version

Version:
unspecified

Attachments

Simple patch to fix the compilation error. (454 bytes, patch)
2007-12-02 08:58 CET , Enrico Tröger
no flags

Additional information