User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.8) Gecko/20071008 Firefox/2.0.0.8 Build Identifier: This problem affects thunar (0.8.0), libxfcegui4 (4.4.1), possibly xfdesktop4 (4.4.1) and others. If a launcher (.desktop file) contains an 'Icon=' line specifying an icon with a period (dot, '.') in the base name, the icon will not be loaded for the launcher. For example, the icon file '0e5b_winamp.0.xpm' would be specified in the .desktop file like so: Icon=0e5b_winamp.0 This icon would, however, not be loaded, while it loads fine in GNOME. This is most noticeable with the icons generated by Wine, which have names resembling the one given in the example above. This happens because the affected software assumes that '.0' is a file extension and strips it from the name before looking for an icon with that base name. So in the example, the software would be looking for an icon named '0e5b_winamp.xpm', or .png, etc., rather than '0e5b_winamp.0.xpm'. Reproducible: Always Steps to Reproduce: 1. Copy an icon file to one of your icon folders, giving it the name 'test.of.it.xpm' or '.png', or whatever format the icon is in 2. Create a launcher on the desktop with any command, xfce4-terminal for instance, and for the icon, locate test.of.periods.xpm, or edit the .desktop file so that the Icon line looks like this: Icon=test.of.it 3. Observe xfce's behavior Actual Results: No icon is visible for this launcher on the desktop or in thuna. Expected Results: It should have checked for the icon with the file name as given *first*. So, before stripping the possible-extension '.it', the icon should be looked for as-is. Then, if it is not found, the possible-extension '.it' should be stripped. This will allow correct compatibility with icon paths that contain an extension and those that don't. Xubuntu 7.10, latest Ubuntu packages; moved from GNOME
Created attachment 1400 Fixes the display problem for launchers on the desktop
Created attachment 1401 Necessary to fix the bug in Thunar another proposed patch - at least something to start
Comment on attachment 1400 Fixes the display problem for launchers on the desktop Editing an affected desktop launcher still shows "No icon" - this needs to be fixed elsewhere
*** Bug 3955 has been marked as a duplicate of this bug. ***
Created attachment 1562 Fixed version for Thunar-0.9.0
This is still valid, especially for some wrong icon names. Anyways this is the wrong idea to strip everything in a given string after "." (a dot) what if a filename contains "-" (a dash) or something more stange ? Wise idea would be to strip graphical extensions: .png or .svg rather than simple . dot WDYT ?
Created attachment 1605 Better patch for Thunar Better patch for Thunar
Ping ?
I wouldn't expect this to get fixed in 4.4.x. Changes are too big for 4.6.0, let's schedule for 4.6.1.
Well i don't care for 4.4.x Too bad i didn't notice sooner this bug wasn't assigned at all.
It seems this patch didn't yet made it to stable release. Could it be scheduled for 4.6.4?
It seems we still apply this one to our builds for 4.9. Could it be applied in master?
Hmh, although we apply this for libxfcegui4, not Thunar :)
I'm not going to submit gui4 patches anymore.
This bus is so old, so now it useless to fix this upstream. Xfce has changed too much.
Close bug reports of archived products.