! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Calender should use GtkToggle in panel
Status:
RESOLVED: FIXED
Product:
Xfce4-datetime-plugin
Component:
General

Comments

Description i80and 2007-08-11 14:51:29 CEST
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.6) Gecko/20070723 Iceweasel/2.0.0.6 (Debian-2.0.0.6-0etch1)
Build Identifier: 

When you click on the datetime plugin to open the calender, and then clock somewhere else, the calender does not close.  You need to click again on the panel plugin to close it.  This defies my expectations, and is unexpected behavior.

Reproducible: Always

Steps to Reproduce:
1. Open datetime calender
2. Try to close calender by moving focus
Actual Results:  
Nothing happens; calender stays.

Expected Results:  
Close the calender.

I'm using version 0.5.0 of the datetime plugin, Xfce 4.4.1, and GTK+ 2.10.13.
Comment 1 Remco den Breeje 2007-08-12 09:21:42 CEST
I'd rather see this as a feature. 
If the calendar closes by losing focus, I expect it to show when the plugin _gets_ focus. Which is unwanted behaviour in my opinion.
Comment 2 i80and 2007-10-20 18:12:25 CEST
(In reply to comment #1)
> I'd rather see this as a feature. 
> If the calendar closes by losing focus, I expect it to show when the plugin
> _gets_ focus. Which is unwanted behaviour in my opinion.
> 

I've thought about it, and yeah, I agree that closeing when losing focus is a bad idea.  However, I've taken the liberty of reopening this bug (sorry if it's just wasting your time), because it would be nice to use a GtkToggleButton to give the user feedback about how to close it.  I know the GNOME time plugin does this, and it's rather nice for a new user to be given some hint like that.
Comment 3 Diego Ongaro 2008-05-02 02:10:27 CEST
Created attachment 1612 
Implements GtkToggleButton in panel

I thought I'd try your idea out. I like it, personally.
Comment 4 Diego Ongaro 2008-05-19 20:30:20 CEST
I'm now the maintainer of datetime, so my opinion actually matters now :)
svn trunk includes this change.

Bug #3456

Reported by:
i80and
Reported on: 2007-08-11
Last modified on: 2010-11-09

People

Assignee:
Diego Ongaro
CC List:
2 users

Version

Version:
unspecified

Attachments

Implements GtkToggleButton in panel (5.70 KB, patch)
2008-05-02 02:10 CEST , Diego Ongaro
no flags

Additional information