! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[feature request] change direction of mouse wheel workspace cycling
Status:
RESOLVED: MOVED

Comments

Description Emanuel Haupt 2007-06-25 16:27:01 CEST
The FreeBSD ports system provides an additional patch that reverses the direction of the mouse wheel workspace cycling. It would be nice if it could be included into the upstream version. Preferably with a changable config option.
Comment 1 Brian J. Tarricone (not reading bugmail) 2007-06-25 16:31:10 CEST
For the record, I'm not in favor of a pref for this, but... up to Olivier.
Comment 2 Erik-Jan 2008-05-06 18:28:02 CEST
Created attachment 1621 
patch to add mouse wheel scroll direction to xfwm-4.4.2
Comment 3 Erik-Jan 2008-05-06 18:28:44 CEST
Created attachment 1622 
adds mouse wheel scroll direction to xfce4-panel-4.4.2
Comment 4 Erik-Jan 2008-05-06 18:29:16 CEST
Created attachment 1623 
adds mouse wheel scroll direction to libxfcegui4-4.4.2
Comment 5 Erik-Jan 2008-05-06 18:29:35 CEST
For those interested: attached are three patches that add configurable mouse wheel workspace cycling direction. They apply to xfce-4.4.2.

The xfwm patch adds the functionality to the window-manager.

The libxfcegui4 and xfce4-panel patches add the functionality to the pager in the panel. Both libxfcegui4 and xfce4-panel patches must be applied to prevent missing symbols-errors.

They can be used independently.
Comment 6 Erik-Jan 2008-11-14 15:30:17 CET
Created attachment 1974 
adds mouse wheel scroll direction switch to xfwm4-4.5.91
Comment 7 Erik-Jan 2008-11-14 15:31:43 CET
Created attachment 1975 
adds mouse wheel scroll direction switch to xfce4-panel-4.5.91
Comment 8 Erik-Jan 2008-11-14 15:32:42 CET
Added two new patches, for 4.5.91 (Beta-1). Only xfwm and xfce4-panel need to
be patched.
Scrolling on the panel now also works if you don't have workspaces but
viewports (like Compiz does).

After applying the xfwm-patch, you need to regenerate
xfwm4-tweaks-dialog_glade.h with these commands:

cd settings-dialogs
exo-csource --static --strip-comments --strip-content \
   --name=tweaks_dialog_glade xfwm4-tweaks-dialog.glade \
   > xfwm4-tweaks-dialog_glade.h
cd ..
Comment 9 Erik-Jan 2008-11-21 20:33:41 CET
Updated for 4.5,92 (4.6-beta2 Hopper)
Comment 10 Erik-Jan 2008-11-21 20:35:31 CET
Created attachment 1996 
adds mouse wheel scroll direction switch to xfce4-panel-4.5.92
Comment 11 Erik-Jan 2008-11-21 20:36:53 CET
Created attachment 1997 
adds mouse wheel scroll direction switch to xfwm4-4.5.92
Comment 12 Olivier Fourdan editbugs 2008-11-21 22:53:02 CET
What do you guys think about this?
Comment 13 Brian J. Tarricone (not reading bugmail) 2008-11-21 23:07:11 CET
Personally I think this pref is silly, and have resisted when people ask for it, but if someone's written the code...
Comment 14 Jasper Huijsmans editbugs 2008-11-22 09:18:32 CET
(In reply to comment #13)
> Personally I think this pref is silly, and have resisted when people ask for
> it, but if someone's written the code...

<grumpy old man mode>
... it's still silly.  Come on, this is equivalent to making the direction of scrollbars configurable, isn't it?  If there are good arguments to change, fine, but let's pick one.
</gumpy old man mode>

Glad to play the Joe Klemmer role here, even if that's all I can do these days ;-)

Feel free to ignore my grumbling.
Comment 15 Jannis Pohlmann editbugs 2008-11-22 11:35:30 CET
I don't think that's really worth an option unless it really helps e.g. RTL people to scroll through the workspaces.
Comment 16 Olivier Fourdan editbugs 2008-11-23 10:54:55 CET
I have no doubt that ppl find that useful since it's been asked several times and we even have a patch here.

But reading the comments, it seems that this is not going to happen for 4.6. But nevertheless, I think it's good to have this patch here in BZ for those who want this option.
Comment 17 Erik-Jan 2011-01-21 22:26:17 CET
Updated these silly patches for 4.8. I still can't get used to the "correct" direction :)
Comment 18 Erik-Jan 2011-01-21 22:28:51 CET
Created attachment 3390 
adds mouse wheel scroll direction switch to xfce4-panel-4.8
Comment 19 Erik-Jan 2011-01-21 22:30:43 CET
Created attachment 3391 
adds mouse wheel scroll direction switch to xfwm-4.8
Comment 20 Harald Judt 2013-03-11 20:22:28 CET
Created attachment 4958 
pager-viewport-switching-support.patch

I'm glad I stumbled over this old bug report! I don't see a reason to not invert the scrolling (mw up = next viewport, mw down = previous viewport, I wonder why it should be done the opposite way, it feels so unnatural!?), so I ripped out that user preference stuff and only kept the viewport.
Comment 21 Harald Judt 2013-03-12 13:03:13 CET
After playing around for a while, I can indeed see a scenario for having such a preference:

a) Pager is configured as one row vertically => scroll direction corresponds to mouse wheel scrolling direction. Scrolling down with the wheel switches to the next workspace/viewport, scrolling up to the previous one. Imagine your workspaces/viewports are aligned vertically too.

b) Pager is configured horizontally, or as having multiple rows => scroll direction corresponds to "inverted" mouse wheel scrolling direction. Scrolling down with the wheel switches to the previous workspace/viewport (like scrolling to the left), scrolling up to the next one (like scrolling to the right).

It's certainly dependent on how you think your workspaces are arranged.

In any case, I wouldn't call that pref silly. As stated (not by me), it's been asked for by other people and has even persuaded someone to write up a patch.

Slightly off-topic: One should note there is a similar strange experience with the gtk slider: Scrolling down increases the values, scrolling up decreases them. I wonder why? Higher values are usually on the top, not on the bottom, so why would you try to scroll _down_ to get higher values?
Comment 22 Michael Kogan 2016-08-18 13:54:39 CEST
Is the patch from 2013 still compatible to the latest Xfce release?
Comment 23 Erik-Jan 2016-08-20 20:47:03 CEST
Created attachment 6781 
adds mouse wheel scroll direction switch to xfce4-panel-4.12.0

Updated patch for xfce4-panel-4.12.0
Comment 24 Erik-Jan 2016-08-20 20:48:48 CEST
Created attachment 6782 
adds mouse wheel scroll direction switch to xfwm4-4.12.3

Updated patch for xfwm4-4.12.3
Comment 25 Michael Kogan 2016-08-22 16:16:13 CEST
Thanks, the patch works and is packaged here: https://aur.archlinux.org/packages/xfce4-panel-compiz/
Comment 26 Michael Kogan 2019-08-24 11:08:10 CEST
Looks like the patch does not work with xfce4-panel 4.14 any more... Any chance, it can be updated to work with new Xfce? Thanks!
Comment 27 Erik-Jan 2019-09-04 18:05:09 CEST
Created attachment 8994 
Updated patch for xfwm4-4.14

Updated patch for xfwm4-4.14
Comment 28 Erik-Jan 2019-09-04 18:12:13 CEST
Created attachment 8995 
don't use the native WnckPager scroll-events

In the miniature-view for the pager-plugin, the native WnckPager events are used, overruling the behaviour-settings done in XFCE. This patch fixes that.
It must be done on top of this commit from git: Fix scrolling in pager-buttons
https://git.xfce.org/xfce/xfce4-panel/commit/?id=55dc7b400feef0c35fda3e8d3515dada2ced29c4
Comment 29 Erik-Jan 2019-09-04 18:14:33 CEST
Created attachment 8996 
adds mouse wheel scroll direction switch to xfce4-panel-4.14

And here is the scroll wheel direction patch for xfce4-panel-4.14.
It must be applied after the WnckPager-patch
Comment 30 Erik-Jan 2019-09-04 18:18:04 CEST
Created attachment 8997 
promotes wrap workspaces from hidden to the properties-UI

For those who want this: the wrap workspaces-toggle is an hidden setting. This patch gives it a place in the panel workspace switcher properties-UI.
It must be applied after the mouse wheel scroll direction-patch (but isn't needed for that patch)
Comment 31 Michael Kogan 2019-09-04 22:13:02 CEST
I tried the patch in comment #28 (also applied the commit you linked beforehand) and it applied cleanly, however, scrolling with Compiz still does not work, so I assume  that this is not the aim of this patch... :) I wonder if an analog for the patch from comment #20 (whyever it was posted in this bug report which deals with a completely different issue) can be created for Xfce 4.14?
Comment 32 Erik-Jan 2019-09-05 15:31:30 CEST
Created attachment 9003 
adds mouse wheel scroll direction switch to xfce4-panel-4.14 v2

I've tested with Compiz but for me it works. Did you only apply the patch from comment #28? That could be the problem; the patch from comment #29 is also needed.

By the way: I noticed a small bug in that patch from comment #29 (greater vs. greater or equal) so here is a new patch.
Comment 33 Michael Kogan 2019-09-06 10:44:34 CEST
Thanks, works perfectly!
Comment 34 Git Bot editbugs 2020-05-29 11:38:01 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/xfwm4/-/issues/6.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #3361

Reported by:
Emanuel Haupt
Reported on: 2007-06-25
Last modified on: 2020-05-29

People

Assignee:
Olivier Fourdan
CC List:
7 users

Version

Attachments

patch to add mouse wheel scroll direction to xfwm-4.4.2 (6.77 KB, patch)
2008-05-06 18:28 CEST , Erik-Jan
no flags
adds mouse wheel scroll direction to xfce4-panel-4.4.2 (3.49 KB, patch)
2008-05-06 18:28 CEST , Erik-Jan
no flags
adds mouse wheel scroll direction to libxfcegui4-4.4.2 (4.57 KB, patch)
2008-05-06 18:29 CEST , Erik-Jan
no flags
adds mouse wheel scroll direction switch to xfwm4-4.5.91 (8.80 KB, patch)
2008-11-14 15:30 CET , Erik-Jan
no flags
adds mouse wheel scroll direction switch to xfce4-panel-4.5.91 (10.27 KB, patch)
2008-11-14 15:31 CET , Erik-Jan
no flags
adds mouse wheel scroll direction switch to xfce4-panel-4.5.92 (10.39 KB, patch)
2008-11-21 20:35 CET , Erik-Jan
no flags
adds mouse wheel scroll direction switch to xfwm4-4.5.92 (8.80 KB, patch)
2008-11-21 20:36 CET , Erik-Jan
no flags
adds mouse wheel scroll direction switch to xfce4-panel-4.8 (11.59 KB, patch)
2011-01-21 22:28 CET , Erik-Jan
no flags
adds mouse wheel scroll direction switch to xfwm-4.8 (9.57 KB, patch)
2011-01-21 22:30 CET , Erik-Jan
no flags
pager-viewport-switching-support.patch (3.57 KB, patch)
2013-03-11 20:22 CET , Harald Judt
no flags
adds mouse wheel scroll direction switch to xfce4-panel-4.12.0 (12.00 KB, patch)
2016-08-20 20:47 CEST , Erik-Jan
no flags
adds mouse wheel scroll direction switch to xfwm4-4.12.3 (9.94 KB, patch)
2016-08-20 20:48 CEST , Erik-Jan
no flags
Updated patch for xfwm4-4.14 (9.57 KB, patch)
2019-09-04 18:05 CEST , Erik-Jan
no flags
don't use the native WnckPager scroll-events (2.89 KB, patch)
2019-09-04 18:12 CEST , Erik-Jan
no flags
adds mouse wheel scroll direction switch to xfce4-panel-4.14 (11.70 KB, patch)
2019-09-04 18:14 CEST , Erik-Jan
no flags
promotes wrap workspaces from hidden to the properties-UI (5.17 KB, patch)
2019-09-04 18:18 CEST , Erik-Jan
no flags
adds mouse wheel scroll direction switch to xfce4-panel-4.14 v2 (11.70 KB, patch)
2019-09-05 15:31 CEST , Erik-Jan
no flags

Additional information