Created attachment 1190 
remove underscore

Underscore is OK. Install gettext.

(In reply to comment #2)
> Underscore is OK. Install gettext.
> 

Hmm.  I already have this on my recently installed F7 machine:

gettext-0.16.1-8.fc7

(In reply to comment #3)
> (In reply to comment #2)
> > Underscore is OK. Install gettext.
> > 
> Hmm.  I already have this on my recently installed F7 machine:
> gettext-0.16.1-8.fc7

Are you sure you have the development version of gettext? Most distros only ship with the version required to RUN programs that use gettext, not the version required to COMPILE programs.

(In reply to comment #4)
> 
> Are you sure you have the development version of gettext? Most distros only
> ship with the version required to RUN programs that use gettext, not the
> version required to COMPILE programs.
> 

Turns out, I didn't have the 'devel' version of the package.  I went ahead and installed it, updated to the latest SVN, and the compile still tanked at the same point:

xfce4_cpufreq_plugin-xfce4-cpufreq-linux.o: In function `cpufreq_linux_init':
/src/work/goodies/xfce4-cpufreq-plugin/trunk/panel-plugin/xfce4-cpufreq-linux.c:401: undefined reference to `_'
collect2: ld returned 1 exit status
make[2]: *** [xfce4-cpufreq-plugin] Error 1
make[2]: Leaving directory `/src/work/goodies/xfce4-cpufreq-plugin/trunk/panel-plugin'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/src/work/goodies/xfce4-cpufreq-plugin/trunk'
make: *** [all] Error 2
[root@hoth trunk]# rpm -qa|grep gettext
gettext-0.16.1-8.fc7
gettext-devel-0.16.1-8.fc7


As before, removing the underscore causes the compile to succeed.  I'll see if I can learn something about gettext and figure this out.

Created attachment 1304 
swapped underscore with gettext

something must be wrong wherever "_" is defined.

The compile is tanking during linking, since it is working on object files. This could mean that it can't find the devel package. I would simply try:

make distclean

this will remove the makefile, and all of the object files that got compiled earlier, when the gettext-dev package was missing. Then try:

./configure && make

Hopefully this helps.

(In reply to comment #7)
> make distclean
> 
> ./configure && make
> 
> Hopefully this helps.
>

Good idea, but it didn't help.  make distclean && ./configure && make resulted in the same error.   I checkout a brand new copy from SVN, ran ./autogen.sh && make, and got the same error.   

I went ahead and downloaded the latest stable tarball from here:

http://goodies.xfce.org/releases/xfce4-cpufreq-plugin/

That one compiled fine with just a ./configure && make

There must be something different between the SVN version and the tarball.  I'll
see if I can track down what it is.

(In reply to comment #8)
> I went ahead and downloaded the latest stable tarball from here:
> 
> http://goodies.xfce.org/releases/xfce4-cpufreq-plugin/

Correct me if I'm wrong, but that tarball is around a year old. (14-Sep-2006 07:03)

Comment 10 Enrico Tröger 2008-02-18 14:40:50 CET

Created attachment 1514 
Patch to fix compilation error because of missing header include

This patch is against current SVN version and fixes the compile error by adding a missing include for a header file.
It also removes some compiler warnings to improve code quality.

Comment 11 Florian Rivoal 2010-12-28 17:06:41 CET

*** Bug 4981 has been marked as a duplicate of this bug. ***

Comment 12 Florian Rivoal 2010-12-29 18:38:38 CET

Thanks for the patch. I applied it (after spliting into smaller parts).