! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Allow use of right-click on removable media
Status:
RESOLVED: FIXED
Severity:
enhancement
Product:
Xfce4-places-plugin
Component:
General

Comments

Description Harold Aling 2007-05-19 12:12:16 CEST
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.3) Gecko/20061201 Firefox/2.0.0.3 (Ubuntu-feisty)
Build Identifier: 

Allow use of right-click on removable media so that you can eject and/or unmount devices from the places plugin...

Reproducible: Always

Steps to Reproduce:
Comment 1 Diego Ongaro 2007-05-23 04:46:17 CEST
Thanks for creating the bug report Harold. I still have your email, but it was getting deeper and deeper in my inbox. FYI: Since I'm not sure this is how I want the plugin to behave, I'll be trying this out in a subversion branch.
Comment 2 Diego Ongaro 2007-05-27 08:51:09 CEST
I made a change to the way the model interfaces with the view so that it now sends along a list of actions with each bookmark, where each action has a label and a callback function. I then modified the view to add a right-click menu with this actions list, and I modified the volumes part of the model to define eject/unmount/mount actions.

Feel free to check out the code with subversion from http://svn.xfce.org/svn/goodies/xfce4-places-plugin/branches/umount/ and try it out. It's far from perfect right now, but it's certainly a start.
Comment 3 Diego Ongaro 2007-06-03 06:59:21 CEST
I touched up some of the logic so that it behaves **much** better.

Harold, can you give the svn branch a try and let me know what you think?
Comment 4 Dieter Plaetinck 2007-06-03 09:49:57 CEST
Additionally, I would enable right-click on *all* items, in order to enable the feature "open terminal here".
When you right-click on an icon on your desktop such as the "home" or "file system" icon you also get this option, I love this and hope this can be put into the "places" plugin too.

When dealing with recent documents the behavior would be to open a terminal in the containing folder.

Lastly, when you right-click on a file-icon on the Desktop (such as a pdf file) you can choose between some possible programs to open the file with, it might be cool if this functionality was added in the "panel" plugin too when right-clicking.
Comment 5 Diego Ongaro 2007-08-05 22:38:52 CEST
Re: "Allow use of right-click on removable media so that you can eject and/or
unmount devices from the places plugin..."

This feature made its way into trunk and it seems fairly stable for me. However, I don't have an optical drive to test with.


Re: "Additionally, I would enable right-click on *all* items, in order to enable the feature \"open terminal here\"."

I agree that this is useful, and this is also in trunk now.


Dieter: Everything you said about recent documents is unfortunately hard to do with the GtkRecentChooserMenu I am using, simply because GtkRecentChooser only provides an "item-activated" signal for me to work with. I don't easily get a signal to use for right-clicking. If you still insist, please open your own bug report.

Bug #3248

Reported by:
Harold Aling
Reported on: 2007-05-19
Last modified on: 2010-11-09

People

Assignee:
Diego Ongaro
CC List:
1 user

Version

Version:
unspecified

Attachments

Additional information