! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Settings are not saved in trunk
Status:
RESOLVED: FIXED
Product:
Xfce4-time-out-plugin
Component:
General

Comments

Description Nick Schermer editbugs 2007-05-09 07:02:20 CEST
xfce_rc_simple_open is set the read-only in the write function, but when you set this to FALSE, some of the settings are not properly restored (when you disable the display time, the settings is still disabled in the properties dialog after a restart, but the time it shown on the panel).
Comment 1 Parminder 2007-06-13 13:59:54 CEST
When "Display remaining time in the panel" is disable, the time display is disabled on the panel. However, when you log-out and log back in, the time is displayed again and "Display remaining time in the panel" check-box becomes enabled. I am assuming that the settings are not being stored and restored properly. 

Reproducibility: Always
Comment 2 Jannis Pohlmann editbugs 2007-07-08 14:42:12 CEST
Fixed in revisions 2751 and 2795:

	* panel-plugin/time-out.c: Fix XfceRc being opened read-only
	  in time_out_save_settings() as reported by Nick. Don't 
	  restart the timer after closing the config dialog when
	  the plugin is not active. 

	* panel-plugin/time-out.c: Save settings when the 'Enabled'
	  checkbox in the panel menu has been toggled.
Comment 3 flg 2010-05-20 13:09:28 CEST
Apparently this bug was fixed and closed  3 years ago but I am experiencing it again.

When Xfce startups and panel loads I always see the remaining time.

But the content of the rc file is :
====
$ cat .config/xfce4/panel/xfce4-time-out-plugin-12690159950.rc 
break-countdown-seconds=3600
lock-countdown-seconds=120
postpone-countdown-seconds=120
enabled=false
display-seconds=false
display-hours=false
display-time=false
====

The Settings window shows the same information as the file ("Display remaining time in the panel" is unset).

I run the latest Xubuntu (10.04) and it's fully up-to-date.

I can't find a version for the plugin itself (the "About" menu item does not show anything) but the Ubuntu package is : 0.1.1svn+r4988-0ubuntu1

IMHO, the problem comes from the fact that the time label is not hide after loading settings if display-time is false.

I will attach a patch that shoudl solve the problem but I honestly don't know if it's the best way to do it.
Comment 4 flg 2010-05-20 13:10:53 CEST
Created attachment 2986 
Remaining time show/hide synchronization with settings on startup
Comment 5 Florian Rivoal editbugs 2010-10-28 16:18:45 CEST
Reopening, to remember investigating it.
Comment 6 Florian Rivoal editbugs 2010-11-05 15:53:57 CET
Looks like a very good approach to me. Thanks for your patch, I just applied it.

Bug #3224

Reported by:
Nick Schermer
Reported on: 2007-05-09
Last modified on: 2010-11-05

People

Assignee:
Florian Rivoal
CC List:
3 users

Version

Version:
0.1.1 or older

Attachments

Additional information