! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Thunar does not create a thumbnail for Ogg/Theora Video
Status:
RESOLVED: FIXED
Product:
Thunar-thumbnailers
Component:
General

Comments

Description Dustin C. Hatch 2007-04-26 14:42:03 CEST
User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.1.3) Gecko/20070326 Firefox/2.0.0.3
Build Identifier: 

When a .ogg file exists in a directory, Thunar does not attempt to create a thumbnail for it, presumably assuming it is Vorbis audio. Perhaps it should check the magic number of the file, rather than the extension, at least in this case.

Reproducible: Always

Steps to Reproduce:
1. Create a Theora video stream in an Ogg Container
2. Open Thunar and enable thumbnailing
3. Navigate to the directory containing the new .ogg file


Actual Results:  
No thumbnail is created for the .ogg file.  MPEGs, etc. that may exist in the same directory are thumbnailed.

Expected Results:  
The Theora video should be thumbnailed as well.

ffmpeg was compiled with theora support.
Comment 1 Erlend Davidson 2007-04-26 15:29:06 CEST
Filetypes are determined by the mimetype of the file.  You can tell what thunar sees the exact mimetype as being by right-clicking the file, go to Properties and hover your mouse over "Ogg multimedia" (or whatever is next to "Kind: ").  The popup says the mimetype.

Could you do this please and tell me the result?

Thanks.
Comment 2 Dustin C. Hatch 2007-04-26 16:45:38 CEST
(In reply to comment #1)
> 
> Could you do this please and tell me the result?
> 
The mime type as reported by thunar is "application/ogg," which is correct.  Both Theora video and Vorbis audio have this mime type. Perhaps files of type application/ogg should be run through ffmpegthumbnailer regardless of their actual content. Vorbis files will simply generate no thumbnail while Theora videos will return a suitable PNG.

I am not a programmer, so I have no idea how you would actually go about this. I would be glad to test, however, if you need.
Comment 3 Dustin C. Hatch 2007-04-26 21:17:55 CEST
I was able to have Thunar create thumbnails for Ogg Theora videos by adding application/ogg to /usr/share/thumbnailers/ffmpeg-thumbnailer.desktop.  This worked well except that it created an entry in ~/.thumbnails/fail/thunar-vfs for every Ogg Vorbis file it encountered. Obviously, this is because ffmpegthumbnailer was unable to create a thumbnail of the file since it is audio only. I am not sure what can be done about this. Perhaps nothing? The files are very tiny, so it may not be a problem.

I guess this stems from the same mime type for anything in an Ogg container. I guess it would be nice to have application/ogg+theora, but that isn't up to any of us :P
Comment 4 Erlend Davidson 2007-04-26 22:01:02 CEST
(In reply to comment #3)
> I was able to have Thunar create thumbnails for Ogg Theora videos by adding
> application/ogg to /usr/share/thumbnailers/ffmpeg-thumbnailer.desktop.  This
> worked well except that it created an entry in ~/.thumbnails/fail/thunar-vfs
> for every Ogg Vorbis file it encountered. Obviously, this is because
> ffmpegthumbnailer was unable to create a thumbnail of the file since it is
> audio only. I am not sure what can be done about this. Perhaps nothing? The
> files are very tiny, so it may not be a problem.
> 

It makes the listing of directories or music unnecessarily slow, so I'm not keen on it.

> I guess this stems from the same mime type for anything in an Ogg container. I
> guess it would be nice to have application/ogg+theora, but that isn't up to any
> of us :P
> 

The proper solution is for ogg video to have a different mimetype from audio. It appears this was discussed on the xiph.org mailing list in 2000 (http://lists.xiph.org/pipermail/vorbis-dev/2000-October/001580.html).  Obviously nothing transpired from this, unfortunately.

Feel free to suggest this to them - I think I will when I get the time.
Comment 5 Erlend Davidson 2007-07-04 12:13:45 CEST
http://wiki.xiph.org/index.php/MIME_Types_and_File_Extensions

It turns out that the intention is to introduce a range of new mimetypes to cover the audio/video issues.  Then this is done is will be much easier.  I suspect application/ogg will be around for some time however, so I should probably thumbnail for it too.
Comment 6 Dustin C. Hatch 2007-07-04 15:36:36 CEST
The other day I noticed, but was too lazy to report, that when there is no extension on a file containing Ogg/Theora video, Thunar shows a MIME-type of video/x-theora+ogg but when the files have an extension of .ogg, the MIME-type is application/ogg.  Not sure what is up with this, but I have just been removing the .ogg extension from my Theora videos and have added the corresponding MIME-type to the thumbnailer .desktop entry.
Comment 7 Erlend Davidson 2007-07-04 16:00:12 CEST
(In reply to comment #6)
> The other day I noticed, but was too lazy to report, that when there is no
> extension on a file containing Ogg/Theora video, Thunar shows a MIME-type of
> video/x-theora+ogg but when the files have an extension of .ogg, the MIME-type
> is application/ogg.  Not sure what is up with this, but I have just been
> removing the .ogg extension from my Theora videos and have added the
> corresponding MIME-type to the thumbnailer .desktop entry.
> 

Well the "x-" prefix means it is a non-standard mimetype: probably your distro has chosen to adopt this pre-empting the change to separate audio/video mimetypes.

Out of curiosity, what distribution do you use?

Thanks for this. I will add video/x-theora-ogg to the mimetypes to be thumbnailed I think.

I've actually today just written a thumbnail handler for application/ogg... in the process of testing it locally before uploading to svn.
Comment 8 Dustin C. Hatch 2007-07-04 16:38:34 CEST
I use Gentoo. Let me know when you get this uploaded to svn and I will check it out from the repository and try it out.  Thanks.
Comment 9 Erlend Davidson 2007-07-04 21:49:51 CEST
(In reply to comment #8)
> I use Gentoo. Let me know when you get this uploaded to svn and I will check it
> out from the repository and try it out.  Thanks.
> 

That's it added.  The ogg thumbnailer will be enabled when --enable-ffmpeg is set.
Comment 10 Samuli Suominen 2007-07-05 17:40:22 CEST
(In reply to comment #9)
> (In reply to comment #8)
> > I use Gentoo. Let me know when you get this uploaded to svn and I will check it
> > out from the repository and try it out.  Thanks.
> > 
> 
> That's it added.  The ogg thumbnailer will be enabled when --enable-ffmpeg is
> set.
> 

Can you ping here, or mail me at drac at gentoo.org once you make a new release with this added? It's an requested feature.
Comment 11 Christoph Mende 2007-07-05 18:46:43 CEST
just FTR: theora thumbnails are fine in an xfce pre4.5 environment on amd64 :>
Comment 12 Erlend Davidson 2007-07-05 20:00:22 CEST
(In reply to comment #11)
> just FTR: theora thumbnails are fine in an xfce pre4.5 environment on amd64 :>
> 

It will if you have totem installed I think (also, so will 4.4).  Thunar can thumbnail quite a lot using the gnome thumbnailers through gconf.  The ffmpeg-thumbnailer and ogg-thumbnailer are lightweight solutions.  If you have totem installed use it, because at the moment it can do everything ffmpeg can do and more (i.e. realmedia 9 and 10).

Has anybody who has tried the ogg-thumbnailer in svn had problems with it?  Based on what Samuli wrote I'd like to release it asap.
Comment 13 Erlend Davidson 2007-07-07 12:50:48 CEST
(In reply to comment #10)
> (In reply to comment #9)
> > (In reply to comment #8)
> > > I use Gentoo. Let me know when you get this uploaded to svn and I will check it
> > > out from the repository and try it out.  Thanks.
> > > 
> > 
> > That's it added.  The ogg thumbnailer will be enabled when --enable-ffmpeg is
> > set.
> > 
> 
> Can you ping here, or mail me at drac at gentoo.org once you make a new release
> with this added? It's an requested feature.
> 

Ok, it's in the 0.2.2 release.
Comment 14 Samuli Suominen 2007-07-07 14:18:32 CEST
(In reply to comment #13)
> Ok, it's in the 0.2.2 release.

Which is now added to Gentoo Portage and works fine. Thanks!

Bug #3183

Reported by:
Dustin C. Hatch
Reported on: 2007-04-26
Last modified on: 2009-07-14

People

Assignee:
Erlend Davidson
CC List:
1 user

Version

Version:
unspecified

Attachments

Additional information