! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Bug when adding All day event from iCal
Status:
CLOSED: FIXED

Comments

Description Ondra Benes 2007-03-26 07:40:52 CEST
User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.1.3) Gecko/20070310 Iceweasel/2.0.0.3 (Debian-2.0.0.3-1)
Build Identifier: 

When Orage takes a All day event from some other resource (.ics) it makes 2 All day event. For example When adding a Meeting on 19.january for all day in Orage it appears At Meeting on 19.january and on 20.january.

Reproducible: Always

Steps to Reproduce:
1. Add to iCal calendar All day evenet
2. Save iCal to a file
3. Open the archive file with Orage

Actual Results:  
Instead of 1 All day event, ii appears two All day event

Expected Results:  
It should be only one All day event

Using resources from Google Calendar. Version of Orage is 4.3.99.2
Comment 1 juha editbugs 2007-03-26 08:17:59 CEST
hm. you are manually editing orage.ics file with vi or something?

Can you attach the VEVENT that you add so that I can try this.
If you add all day meeting from Orage it works? So there must be something in that
manually added VEVENT that Orage can't understand, so I need to see it.

I don't understand the archive file connection here? DO you see the error only
after it has been archived?
Comment 2 Ondra Benes 2007-03-26 08:34:52 CEST
Created attachment 1060 
Testing google calendar .ics file
Comment 3 Ondra Benes 2007-03-26 08:36:45 CEST
I made a test calednar on Google calednar and add there one All day event. 

I use a small script which removes orage.ics with .ics file from google, I'm not using the archive function from menu.
Comment 4 juha editbugs 2007-03-26 09:46:23 CEST
Your test VEVENT is:
BEGIN:VEVENT
DTSTART;VALUE=DATE:20070330
DTEND;VALUE=DATE:20070331
DTSTAMP:20070326T083407Z
ORGANIZER;CN=Orage test:MAILTO:l30hl01b7nioifqj5sok0k1tno@group.calendar.go
 ogle.com
UID:n6tchukp4a3ug38kagmqjtkoo4@google.com
CLASS:PRIVATE
CREATED:20070326T082748Z
LAST-MODIFIED:20070326T082822Z
SEQUENCE:1
STATUS:CONFIRMED
SUMMARY:Test
TRANSP:TRANSPARENT
END:VEVENT

ical stańdard rfc2445 says:
   The "VEVENT" is also the calendar component used to specify an
   anniversary or daily reminder within a calendar. These events have a
   DATE value type for the "DTSTART" property instead of the default
   data type of DATE-TIME. If such a "VEVENT" has a "DTEND" property, it
   MUST be specified as a DATE value also. The anniversary type of
   "VEVENT" can span more than one date (i.e, "DTEND" property value is
   set to a calendar date after the "DTSTART" property value).


So you have
DTSTART;VALUE=DATE:20070330
DTEND;VALUE=DATE:20070331

which Orage intercepts as 1 event which spans two days:
 The anniversary type of
   "VEVENT" can span more than one date (i.e, "DTEND" property value is
   set to a calendar date after the "DTSTART" property value).



I believe this works as expected. If you only want 1 day event, remove DTEND
(or set it to be the same day)

I hope you see only 1 event, which spans two days?

(By the way, Orage 4.5 has much better support for these external calendars.
I recommend you install it from SVN if possible for you? Orage 4.5 has export
functionality, which you actually use here.)
Comment 5 Ondra Benes 2007-03-26 10:52:33 CEST
yes, I see one event which spans two days. THX for info, I'll try the SVN version ;) hope that will work on my Debian :P.
Comment 6 juha editbugs 2007-03-26 19:39:27 CEST
I believe this is not a bug. setting it invalid.
Comment 7 Ondra Benes 2007-03-26 19:54:50 CEST
Yeah, you're right. But I was (and still I am) confused if I had someones birthday in calednar and it appers on two days. So if I understand it well, one day event should look like this

DTSTART;VALUE=DATE:20070330
DTEND;VALUE=DATE:20070330

If yes, then people from Google made a mistake and this bugreport should belong them. But if no, I'm still confused.
Comment 8 juha editbugs 2007-03-26 21:00:23 CEST
Sorry for this! I read the docs again and indeed ENDDATE is non-inclusive, so
Orage works wrong. You can leave the ENDDATE out, but if you set it, you need
to use next day.

I reopened and will fix this.

Comment 9 juha editbugs 2007-03-26 21:01:27 CEST
tested also with evolution and it works same way than Google.
Comment 10 juha editbugs 2007-04-03 21:36:04 CEST
This is now fixed in trunk svn revision 25375 (4.5.9.1 Orage).

Basically this is invisible in production 4.4 version of Orage since
there is no public way to exchange data with other ical sources,
Comment 11 juha editbugs 2007-04-04 18:36:46 CEST
Backported fix into 4.4 svn revision 25381.
Will appear in Xfce 4.4.1 version of Orage.
Comment 12 juha editbugs 2007-04-12 08:44:37 CEST
4.4.1 was released

Bug #3058

Reported by:
Ondra Benes
Reported on: 2007-03-26
Last modified on: 2007-04-12

People

CC List:
0 users

Version

Version:
unspecified

Attachments

Testing google calendar .ics file (951 bytes, text/calendar)
2007-03-26 08:34 CEST , Ondra Benes
no flags

Additional information