! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfce4-session does not check if some instance of gnome-keyring-daemon is runn...
Status:
RESOLVED: FIXED
Product:
Xfce4-session
Component:
General

Comments

Description Konrad Klimaszewski 2007-03-13 15:18:05 CET
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.2) Gecko/20061201 Firefox/2.0.0.2 (Ubuntu-feisty)
Build Identifier: 

When "Launch Gnome services on startup" is selected xfce4-session spawns gnome-keyring-daemon (which is good thing).

Unfortunately it seems to not check if another instance of gnome-keyring-daemon is running already. This brakes pam-keyring functionality. pam-keyring spawns gnome-keyring-daemon and unlocks default keyring using login password. Then xfce4-session spawns another instance of gnome-keyring-daemon in which default keyring is not unlocked - and this leads to keyring password popup.

This was tested under Xubuntu 7.04 Herd5

Reproducible: Always

Steps to Reproduce:
1. Install libpam-keyring http://johnny.chadda.se/2007/02/21/unlock-the-gnome-keyring-upon-login
2. Set in session manager options "Launch Gnome services on startup" to ON
3. Log on to Xfce
4. Start Evolution, Gajim, NetworkManager Applet or any other app that uses gnome-keyring

Actual Results:  
One gets an popup asking for a password to unlock the keyring.

Expected Results:  
No popup should have appeared. The keyring should have been unlocked by pam module.

Now if one disables "Launch Gnome services on startup" everything works fine..
Comment 1 wolf 2007-05-05 21:19:37 CEST
i can confirm this bug on my system
Comment 2 Olivier Fourdan editbugs 2008-07-07 20:44:17 CEST
Created attachment 1734 
Patch for compatibility with gnome-keyring 2.22

This patch works only with gnome 2.22 and above - The API used in previous versions of libgnome-keyring is deprecated so it does not make sense to look for compatibility with previous versions IMHO.

Anyway, Benny, please consider for inclusion in 4.6
Comment 3 Brian J. Tarricone (not reading bugmail) 2008-09-15 09:17:33 CEST
Olivier, have you tested this patch yourself?  I don't have gnome-keyring installed, but the patch looks ok to me semantically, assuming you already checked what those 2 gnome-keyring API function calls do ^_^.
Comment 4 Brian J. Tarricone (not reading bugmail) 2008-10-07 11:43:26 CEST
Ok, it builds, so I'm checking it in to trunk (with a build fix when gnome-keyring libs isn't installed).  Also moved the gnome-keyring-1 check out of HAVE_GNOME, cuz they aren't really dependent on one another.  Hopefully people who use gnome-keyring can test it.

Bug #3007

Reported by:
Konrad Klimaszewski
Reported on: 2007-03-13
Last modified on: 2009-07-14

People

Assignee:
Brian J. Tarricone (not reading bugmail)
CC List:
2 users

Version

Attachments

Additional information