! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfdesktop spawns zombies
Status:
RESOLVED: FIXED
Product:
Thunar-vfs
Component:
General

Comments

Description cyberf0x 2007-03-06 21:49:53 CET
The problem seems to be with xfdesktop and the /Desktop entries.
Every time  I run any app from the desktop after some time of using it and closing it with File->Exit or X it spawns a zombie.
Anyway running apps from Terminal this way: ./some_app & or from menu works fine.
Now I have some ./firefox <defunct> entries, some ./opera <defunct> entries, and few another <defunct> entries.

Reproductible: Always

Steps:
1.Install XFCE from installer or distribution packages (no matter).
2.Run antyhing from the desktop which was a KDE shortcut before.
3.Play with your app some time and close it.
4.Watch ps list.

Result: huge army of zombies :]

Expected: no zombies
Comment 1 Brian J. Tarricone (not reading bugmail) 2007-03-06 22:28:04 CET
What's a "KDE shortcut"?  I can't reproduce this with normal .desktop-style shortcuts.
Comment 2 cyberf0x 2007-03-07 00:56:50 CET
(In reply to comment #1)
> What's a "KDE shortcut"?  I can't reproduce this with normal .desktop-style
> shortcuts.
> 

I mean I use KDE most of the time, so it also uses /Desktop directory for it's shortcuts. I don't know if it is its special style of .desktop files or is it a part o some standard (freedesktop.org?) all I know is I close KDE, open XFCE, and I see the same shortcuts(icons) on my desktop. I run any of them and after closing app I get <defunct> in ps list.
At first I thought it was some kind of distribution problem (Mandriva) so I removed xfce 4.4.0 rpms and downloaded XFCE Installer and compiled it without optimizations but it's still the same.
I don't know, maybe it's a .desktop files problem in Mandriva. I can't check this with other distros.
Comment 3 cyberf0x 2007-03-07 01:43:47 CET
Created attachment 1020 
firefox straced zombie
Comment 4 cyberf0x 2007-03-07 01:44:24 CET
Created attachment 1021 
firefox straced zombie result
Comment 5 cyberf0x 2007-03-07 01:45:53 CET
I've attached shortcut made under KDE and a strace result.
Maybe this will help you.
Comment 6 Brian J. Tarricone (not reading bugmail) 2007-03-07 01:56:34 CET
Looks like KDE's shortcut files are just normal .desktop files.

Benny, any ideas here?  I'm just using thunar_vfs_info_execute() to launch .desktop files.
Comment 7 cyberf0x 2007-03-12 03:32:45 CET
Ok, this is weird :]. I removed entire StartupNotify line from the attached .desktop file and It works now(no zombies). I'll have to do some more tests but it seems to be it.

Comment 8 David Keogh 2007-03-16 14:45:34 CET
This bug seems to affect thunar (0.8.0) as well. I examined some desktop files and it does seem that only desktop files with StartupNotify=true will leave behind zombies.
Comment 9 Brian J. Tarricone (not reading bugmail) 2007-05-05 18:05:49 CEST
Pretty sure this isn't an xfdesktop problem...
Comment 10 Chris Carlin 2007-05-15 23:05:50 CEST
I'm seeing this for both xfdesktop and Thunar when using gnumeric.

In short, doubleclicking on a .gnumeric file in either will launch gnumeric, but after quitting the program the zombie is left behind:

 7708 ?        00:00:03 Thunar
12152 ?        00:00:01  \_ gnumeric <defunct>
24509 ?        00:00:00  \_ gnumeric <defunct>
 7712 ?        00:00:29 xfdesktop
14447 ?        00:00:02  \_ gnumeric <defunct>
25427 ?        00:00:04  \_ gnumeric <defunct>
25454 ?        00:00:12  \_ gnumeric <defunct>
Comment 11 Nick Schermer editbugs 2007-05-24 10:56:54 CEST
Created attachment 1153 
Prevent zombies

The panel in trunk had similar problems using the same code as Thunar and a patch like this one seems to fix the problems. I'm not really sure if this is the best way to fix it, but it's a start...
Comment 12 Jérôme Guelfucci editbugs 2007-11-16 17:06:03 CET
Mandriva seems to have applied a patch for this: http://rpmfind.net/linux/RPM/mandriva/devel/cooker/x86_64/media/contrib/release/thunar-0.8.0-8mdv2008.0.x86_64.html
(see their changelog)

Ubuntu bug for this: https://bugs.launchpad.net/ubuntu/+source/thunar/+bug/163106
Comment 13 Lionel Le Folgoc 2007-11-16 18:47:35 CET
(In reply to comment #12)
> Mandriva seems to have applied a patch for this:
> http://rpmfind.net/linux/RPM/mandriva/devel/cooker/x86_64/media/contrib/release/thunar-0.8.0-8mdv2008.0.x86_64.html
> (see their changelog)
> 

It seems that mandriva applied the patch attached to this bug.

Comment 14 Miguel Angel 2007-12-02 17:49:40 CET
Thunar 0.9.0 has been released without fix this bug? why? is a really annoying bug that distributions are patching on his side with the patch in this report.
Comment 15 Benedikt Meurer editbugs 2007-12-02 17:51:43 CET
The patch is really a hack.
Comment 16 Miguel Angel 2007-12-02 17:54:10 CET
wow what a fast reply :), sorry i didnt know, i am using it in my machines but i suppose a real patch would be too much work for this version.
Comment 17 Benedikt Meurer editbugs 2007-12-02 17:56:08 CET
Honestly, I simply forgot about this bug (was not on my ASSIGNED list yet). I'll try to come up with a patch.
Comment 18 Benedikt Meurer editbugs 2007-12-02 18:09:42 CET
Created attachment 1451 
Suggested fix

This patch should do the trick.
Comment 19 Miguel Angel 2007-12-02 18:13:39 CET
i will test it tomorrow and post here my results thanks Benedikt.
Comment 20 Benedikt Meurer editbugs 2007-12-02 18:13:49 CET
Created attachment 1452 
Better fix

Err, the previous one was bogus. This one should do.
Comment 21 Miguel Angel 2007-12-03 17:33:34 CET
Benedikt your patch works very well with Thunar 0.8.0 and it seems that all xfce it is much more responsive in this version 4.4.2, or i am very optimistic hehehe
Comment 22 Benedikt Meurer editbugs 2007-12-03 17:50:46 CET
Committed with revision 26432.

2007-12-03	Benedikt Meurer <benny@xfce.org>

	* thunar-vfs/thunar-vfs-exec.c: Make sure, processes spawned from
	  Thunar and xfdesktop are properly joined. Bug #2983.

Comment 23 Benedikt Meurer editbugs 2008-03-15 16:04:33 CET
*** Bug 3942 has been marked as a duplicate of this bug. ***
Comment 24 Christoph Wickert editbugs 2008-10-28 09:31:07 CET
I still don't see this fix in 0.9.3.

Bug #2983

Reported by:
cyberf0x
Reported on: 2007-03-06
Last modified on: 2010-11-07
Duplicates (1):
  • 3942 many processes launched by Thunar become defunct/zombie after close

People

Assignee:
Jannis Pohlmann
CC List:
10 users

Version

Version:
unspecified

Attachments

firefox straced zombie (339 bytes, text/plain)
2007-03-07 01:43 CET , cyberf0x
no flags
firefox straced zombie result (19.59 KB, text/plain)
2007-03-07 01:44 CET , cyberf0x
no flags
Prevent zombies (1.22 KB, patch)
2007-05-24 10:56 CEST , Nick Schermer
no flags
Suggested fix (1.16 KB, patch)
2007-12-02 18:09 CET , Benedikt Meurer
no flags
Better fix (1.08 KB, patch)
2007-12-02 18:13 CET , Benedikt Meurer
no flags

Additional information