User-Agent: Mozilla/5.0 (X11; U; SunOS sun4u; fr-FR; rv:1.8.1) Gecko/20061228 Firefox/2.0 Build Identifier: The code xfdesktop-icon-view.c and desktop-menu.h use the __FUNCTION__ macro which is not standardized and does not compile with SunStudio C compiler. It should be replaced by __func__ Reproducible: Always
Created attachment 1008 Replace __FUNCTION__ by __func__
__func__ isn't defined everywhere either, so can't use that. I just removed the redundant BD() stuff in the menu code (just use the libxfce4util DBG() macro instead), and modified the icon view macro to just print using DBG() as well. Really though: building in debug mode is intended for developers (at least how I see it), though of course it's useful for users trying to track down problems. I'm not really too concerned if debug mode fails on a few minority compilers/arches.
Hi > __func__ isn't defined everywhere either, so can't use that. I just removed > the redundant BD() stuff in the menu code (just use the libxfce4util DBG() > macro instead), and modified the icon view macro to just print using DBG() as > well. Thanks. I think i'll submit soon a small patch to libxfce4util since the GDB macro is not using __func__ for sunstudio CC but "??". One test is missing from the #ifdef stuff. > Really though: building in debug mode is intended for developers (at least how > I see it), though of course it's useful for users trying to track down > problems. I'm not really too concerned if debug mode fails on a few minority > compilers/arches. I am working to update the Solaris packages for Blastwave. Since i had a few problems i compiled in debug mode on my box to understand what's going on with my problem. Of course i'll switch to final when i will have fixed my packaging problems. Thank you for your quick answer.
> __func__ isn't defined everywhere either, so can't use that. __func__ is a c99 predefined identifiers (section 6.4.2.2 in the c99 spec file).
(In reply to comment #4) > > __func__ isn't defined everywhere either, so can't use that. > > __func__ is a c99 predefined identifiers (section 6.4.2.2 in the c99 spec > file). > And we don't require a c99-capable compiler...