Created attachment 978 
hal-device output

Comment 2 Benedikt Meurer 2007-02-04 11:48:44 CET

Are you talking about the thunar-volman? Because Thunar doesn't start gtkpod.

Yes, sorry.  thunar-volman isn't available in the dropdown.

Comment 4 Benedikt Meurer 2007-02-12 19:37:38 CET

It's part of the 'Thunar Plugins' product... Back to the issue: thunar-volman detects audio player asking HAL whether the storage device has the portable_audio_player capability. So HAL seems to detect your flash drive incorrectly.

I just noticed that it starts gtkpod any time any removable media is inserted, whether it's my iPod, USB stick or just a cdrom.

Comment 6 Benedikt Meurer 2007-02-12 23:01:31 CET

Are you sure that it's thunar-volman launching gtkpod?

Yes.  When I uncheck the start audio player box in the thunar-volman prefs the problem goes away.

Hi,

I had the same problem. It set gtkpod as the command for "portable music players", and now gtkpod starts when I:

- plug in my iPod (good)

- plug in my external firewire hard disk (bad)

- plug in my USB card reader with the CF from the camera (bad)

- insert a DVD (bad)

Maybe even more.

I looked into the source code of tvm-block-device.c. The command seems to be "autoipod_command". There is a tvm_block_device_autoipod() function that checks new block devices for the "portable_audio_player" HAL capability:

if (libhal_device_query_capability (context, storage_udi, "portable_audio_player", NULL))

However, at the end of the function, the result of this capability check is ignored and the "response" variable is set to "TVM_RESPONSE_MUSIC" regardless of this capability check, so that every block device is handled as a music player.

Created attachment 1296 
limit the autoipod_command to music players

This patch only sets response to TVM_RESPONSE_MUSIC when the HAL capability check for "portable_audio_player" was successful. Now gtkpod only starts when I plug in the iPod. It doesn't start anymore when I insert a DVD, plug in the card reader or plug in the firewire hard disk.

P.S.: The patch is for thunar-volman 0.1.2.

Created attachment 1297 
fix check for VIDEO_TS on inserted DVDs

Now I tried the same with a DVD command. It was never executed.

The reason was a check for the video path. If I change it from video_ts to VIDEO_TS, then it works.

I think the "video_ts" check works in the case that the DVD is automounted as ISO9660 instead of UDF. However, for me, it is mounted as UDF:

/dev/scd0 on /media/CDROM type udf (ro,nosuid,nodev,uid=1001)

This patch also checks for "VIDEO_TS". Now my DVDs are detected as they should.

Comment on attachment 1297 
fix check for VIDEO_TS on inserted DVDs

This patch doesn't really belong here, I also attached it to Bug #3038, which is more appropriate.

Created attachment 1542 
updated patch 

I can confirm this bug and the patch works. I'd add initialisation of response, though, as in the attached patch.

Would it be possible to get that in SVN? :)

Comment 14 Benedikt Meurer 2008-03-15 09:33:59 CET

Committed revision with 4057.

2008-03-15      Benedikt Meurer <benny@xfce.org>

        * thunar-volman/tvm-block-device.c: Apply patch from Tino Keitel
          and Colin Leroy to fix USB flash drives being incorrectly
          recognized as audio players. Bug #2856.