! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xarchiver does not compile due to missing mkdtemp() on solaris 2.8
Status:
RESOLVED: FIXED
Product:
Xarchiver
Component:
general

Comments

Description Thomas Wiegner 2007-01-23 13:29:18 CET
User-Agent:       Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.8.1) Gecko/20061024 Firefox/2.0
Build Identifier: 

See also Bug 2277, the applied bugfix is incomplete. The mkdtemp is 
function was added as a static function to string_utils.c, but 
is invisible to the extract_dialog.c where it is used.

Here is a patch to fix this:

----------------------------------------------->

--- string_utils.h_old  2007-01-23 14:13:52.666054000 +0100
+++ string_utils.h      2007-01-23 14:14:21.495182000 +0100
@@ -22,6 +22,9 @@
 #ifndef HAVE_STRCASESTR
 const char *strcasestr(const char *haystack, const char *needle);
 #endif
+#ifndef HAVE_MKDTEMP
+char *mkdtemp (gchar *tmpl);
+#endif
 gchar *EscapeBadChars ( gchar *string , gchar *pattern);
 gchar *JoinPathArchiveName ( const gchar *extract_path , gchar *path );
 int CountCharacter ( gchar *string , int chr );

--- string_utils.c_old  2007-01-23 14:12:36.868281000 +0100
+++ string_utils.c      2007-01-23 14:12:45.697979000 +0100
@@ -27,7 +27,7 @@
 #include "errno.h"

 #ifndef HAVE_MKDTEMP
-static char *mkdtemp (gchar *tmpl)
+char *mkdtemp (gchar *tmpl)
 {
        static const gchar LETTERS[] = "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789";
        static guint64     value = 0;

<---------------------------------------------------------


Reproducible: Always

Steps to Reproduce:
Comment 1 Giuseppe Torelli 2007-01-23 13:35:02 CET
I already applied your patch in my local sources. Thank you for your appreciated contribution.
Comment 2 Giuseppe Torelli 2007-01-31 13:14:55 CET
Fixed in r24798.

Bug #2799

Reported by:
Thomas Wiegner
Reported on: 2007-01-23
Last modified on: 2007-01-31

People

Assignee:
Giuseppe Torelli
CC List:
0 users

Version

Attachments

Additional information