! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Fix xfce4-netload-plugin-0.4.0 building with -Wl,--as-needed [PATCH]
Status:
CLOSED: DUPLICATE
Product:
Xfce4-netload-plugin
Component:
General

Comments

Description Samuli Suominen 2007-01-21 21:16:26 CET
Attaching a fix.
Comment 1 Samuli Suominen 2007-01-21 21:17:26 CET
Created attachment 947 
ldflags-asneeded.patch

Thanks, Samuli
Comment 2 Eric Sandall 2009-05-09 01:55:27 CEST
This fixes the issue for me, though I applied it to Makefile.in instead of Makefile.am, since .am requires autoreconf, which fails with syntax errors during configure.
Comment 3 Samuli Suominen 2009-07-09 22:29:51 CEST
(In reply to comment #2)
> This fixes the issue for me, though I applied it to Makefile.in instead of
> Makefile.am, since .am requires autoreconf, which fails with syntax errors
> during configure.

This is because you need xfce4-dev-tools and you need to point them to autotools, like so:

AT_M4DIR="/usr/share/xfce4/dev-tools/m4macros" autoreconf

Assuming the xfce4-dev-tools pkg gets installed to this directory, but just to serve as an example
Comment 4 Samuli Suominen 2009-07-09 22:31:17 CEST
Eric, changing Makefile.in might still trigger maintainer mode in autotools, which is why Makefile.am should be patched instead :)
Comment 5 Mike Massonnet editbugs 2009-07-13 10:26:03 CEST
When you patch a Makefile.in file you just need to rerun ./configure (or ./config.status if you want only to regenerate the .in files).
Comment 6 Samuli Suominen 2009-07-13 12:52:35 CEST
(In reply to comment #5)
> When you patch a Makefile.in file you just need to rerun ./configure (or
> ./config.status if you want only to regenerate the .in files).

But if you change Makefile.in and the timestamp changes, and "Maintainer mode" is present in the fileset; It will trigger autoconf to be run again and if the versions has changed, there's a good possibility it will fail -- systems vary.
Comment 7 Florian Rivoal editbugs 2010-10-14 17:47:23 CEST
This issue was resolved when applying the fix for 6466

*** This bug has been marked as a duplicate of bug 6466 ***

Bug #2782

Reported by:
Samuli Suominen
Reported on: 2007-01-21
Last modified on: 2012-01-13

People

Assignee:
Bernhard Walle
CC List:
3 users

Version

Version:
0.4.0 or older

Attachments

ldflags-asneeded.patch (549 bytes, patch)
2007-01-21 21:17 CET , Samuli Suominen
no flags

Additional information