! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Feature request/question: merge with xfce4-taskmanager / popup task list
Status:
RESOLVED: FIXED
Severity:
enhancement
Product:
Xfce4-systemload-plugin
Component:
General

Comments

Description Harold Aling 2007-01-05 10:47:49 CET
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.1) Gecko/20060601 Firefox/2.0.0.1 (Ubuntu-edgy)
Build Identifier: 

Xfce4-taskmanager is full of bugs, but the only GTK2 process manager available.

The maintainer doesn't respond to messages on the goodies-dev list, hence my request/question if xfce4-systemload could be expanded to popup a list of processes where you can modify/stop them, just like xfce4-taskmanager does. (but without all the bugs;)

Reproducible: Always

Steps to Reproduce:




I found these 'bugs' in xfce4-taskmanager. I'm almost sure there are more like these, as I didn't compare all to (h)top output
* Other memory usage indication: almost always 95-100% where the "System load monitor" -for example- only reports ~20-25% usage
* Adding up cpu usage is always more than the top indicator indicates
* Ability to use 101+% cpu
* Cpu usage with decimal (0,0) notation, but it's never used (only integers)
Comment 1 Álvaro Lopes 2007-01-05 14:57:51 CET
I can fix some parts on the xfce4-taskmanager, if the maintainer is unavailable.

I don't think the systemload should be process-aware. 

What exactly do you mean by "modify" the processes? Send signals? Start/stop?
Comment 2 Harold Aling 2007-01-05 15:20:47 CET
> What exactly do you mean by "modify" the processes? Send signals? Start/stop?
> 

The same as currently available through xfce4-taskmanager: Stop, Continue, Terminate and Kill.

In fact the whole interface of xfce4-taskmanager is fine, except for almost all the information displayed in it...
Comment 3 Álvaro Lopes 2007-01-11 10:26:44 CET
Created attachment 933 
Fix the CPU and memory usage.

This patch fixes CPU usage by reading /proc/stat directly.
Also adds an option to show memory used by cache as free memory (as most applications do).
Comment 4 Harold Aling 2007-01-11 21:28:59 CET
Created attachment 936 
CPU usage differences (htop/xfce4-taskmanager)

Álvaro,

I tested your patch and it solves a lot of bugs, thank you!

As you can see in the attached image, the cpu usage is still a bit off, especially when you add up the cpu usage in the list and compare it with the top cpu-usage-bar...

I have a P$ that uses hyper threading (2 fake processors), maybe that's what make the difference...

Thanx for the patch! I hope it gets merged soon...

-H-
Comment 5 Álvaro Lopes 2007-01-12 10:22:39 CET
Yes, I still have to fix that. 

The per-task CPU usage does not account for multiple CPUs yet. I have to find an elegant way to do that.

And I believe there is some miscalculation somewhere (that one causing the CPU usage to always be an integer, even if your HZ is higher than 100). Would be acceptable and correct for 1 CPU and HZ=100, because it samples one second and there is a perfect match between percentage and number of jiffies.

I'll take a look ASAP.

Comment 6 Nick Schermer editbugs 2007-01-12 17:20:00 CET
committed, but please test your patches next time and also fix all the compiler warnings.

Bug #2714

Reported by:
Harold Aling
Reported on: 2007-01-05
Last modified on: 2010-10-28

People

Assignee:
Xfce-Goodies Maintainers
CC List:
1 user

Version

Version:
0.4.2 or older
Target Milestone:
0.4.2 or older

Attachments

Fix the CPU and memory usage. (9.76 KB, patch)
2007-01-11 10:26 CET , Álvaro Lopes
no flags
CPU usage differences (htop/xfce4-taskmanager) (46.90 KB, image/png)
2007-01-11 21:28 CET , Harold Aling
no flags

Additional information