! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Compile warnings which block compilation if warnings are treated as errors
Status:
RESOLVED: FIXED
Product:
Xfce-mcs
Component:
Plugins

Comments

Description Joao Pedrosa 2006-11-05 08:23:44 CET
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; pt-BR; rv:1.8.1) Gecko/20060601 Firefox/2.0 (Ubuntu-edgy)
Build Identifier: 

I was compiling a new Xfce from scratch, and I think I've found the following issue:

 gcc -DHAVE_CONFIG_H -I. -I. -I../.. -I../.. -I../../plugins/gtk_common -I../.. -DLOCALEDIR=\"/opt/xfce-dev/share/locale\" -DDATADIR=\"/opt/xfce-dev/share\" -I/opt/xfce-dev/include/xfce4 -I/usr/include/gtk- 2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/cairo -I/usr/include/atk-1.0 -I/opt/xfce-dev/include/xfce4 -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0 /include -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/cairo -I/usr/include/atk-1.0 -fno-strict-aliasing -Werror -Wall -g -O2 -g -Wall -DXFCE_DISABLE_DEPRECATED -MT ui_plugin_la-ui_plugin.lo -MD -MP -MF .deps/ui_plugin_la-ui_plugin.Tpo -c ui_plugin.c  -fPIC -DPIC -o .libs/ui_plugin_la-ui_plugin.o
cc1: warnings being treated as errors
ui_plugin.c: In function 'create_theme_dialog':
ui_plugin.c:702: warning: implicit declaration of function 'xfce_framebox_new'
ui_plugin.c:702: warning: assignment makes pointer from integer without a cast
ui_plugin.c:710: warning: implicit declaration of function 'xfce_framebox_add'
ui_plugin.c:710: warning: implicit declaration of function 'xfce_framebox_get_type'
ui_plugin.c:726: warning: assignment makes pointer from integer without a cast
ui_plugin.c:754: warning: assignment makes pointer from integer without a cast
ui_plugin.c:763: warning: assignment makes pointer from integer without a cast
ui_plugin.c:778: warning: assignment makes pointer from integer without a cast
ui_plugin.c:790: warning: assignment makes pointer from integer without a cast
make[3]: ** [ui_plugin_la-ui_plugin.lo] Erro 1
make[3]: Saindo do diretório `/home/dewd/t_/test_downloads/xfce/xfce-mcs-plugins/plugins/ui_plugin'
make[2]: ** [all-recursive] Erro 1
make[2]: Saindo do diretório `/home/dewd/t_/test_downloads/xfce/xfce-mcs-plugins/plugins'
make[1]: ** [all-recursive] Erro 1
make[1]: Saindo do diretório `/home/dewd/t_/test_downloads/xfce/xfce-mcs-plugins'
make: ** [all] Erro 2
Error while processing module xfce-mcs-plugins
Error: while running command make

Reproducible: Always
Comment 1 Jean-François Wauthy editbugs 2006-11-05 08:49:51 CET
did you use --enable-debug with ./configure ?
Comment 2 Olivier Fourdan editbugs 2006-11-05 08:58:34 CET
Major is like a severe crash in a core components, or even a security issue. Compilation warnings are by no means "major".
Comment 3 Joao Pedrosa 2006-11-05 09:05:58 CET
(In reply to comment #1)
> did you use --enable-debug with ./configure ?
> 

My build script is simple and as generic as possible for all the Xfce modules that I build. Currently, I run:

"./autogen.sh --prefix=/opt/xfce-dev/"

By default, instead of configure. Thus, if "enable-debug" is turned on, it's because autogen.sh defaults to it. :-) But it's funny that I built Xfce a couple of days ago with this same build script, and at the time I didn't have this error. Thus I thought it was a change recently introduced and that needed to be fixed.
Comment 4 Benedikt Meurer editbugs 2006-11-05 09:09:31 CET
Replace deprecated functions or drop -DXFCE_DISABLE_DEPRECATED? I'd vote for the latter now that we're close to final.
Comment 5 Olivier Fourdan editbugs 2006-11-05 09:39:54 CET
Please, don't change the priority to major if I say it's minor. I don't care about you build script.

Comment 6 Joao Pedrosa 2006-11-05 10:00:24 CET
(In reply to comment #5)
> Please, don't change the priority to major if I say it's minor. I don't care
> about you build script.
> 

I didn't change on purpose anything. I first set it to major mistakenly and you corrected it and me, but then I didn't change it back to major, though I was answering to Pollux and not to you, and Bugzilla complained about some sort of conflict after you added your comment and I was already answering to Pollux (Jean).

Geez.
Comment 7 Olivier Fourdan editbugs 2006-11-05 10:35:39 CET
(In reply to comment #6)

> I didn't change on purpose anything. I first set it to major mistakenly and you
> corrected it and me, but then I didn't change it back to major[...]

Ok, my apologies. It's fixed now anyhow.

Bug #2500

Reported by:
Joao Pedrosa
Reported on: 2006-11-05
Last modified on: 2009-07-14

People

Assignee:
Xfce Bug Triage
CC List:
0 users

Version

Attachments

Additional information