User-Agent: Opera/9.02 (X11; Linux i686; U; de) Build Identifier: It would be useful if Thunar would show the exact MIME type of a file, as the „Type“ currently shown is sometimes not accurate enough. Reproducible: Always
Where? I could add that as tooltip to the "Kind" label in the properties dialog.
If you don’t want to clutter the interface, then that’s a good solution, yes.
Created attachment 810 Possible patch
The patch could not be applied successfully. I’ll attach the .rej file.
Created attachment 811 rejected changes from patch
Created attachment 812 The new source file Weird. Don't you run the latest SVN? Anyway here's the new source file, just override your current one.
> Weird. Don't you run the latest SVN? No, I’m using the sources from my Debian repository. > Anyway here's the new source file, just override your current one. Since this one is newer I’m getting problems with compiling now: Thunar-thunar-properties-dialog.o: In function `thunar_properties_dialog_update': /home/ashura/Archive/deb/xfce/Thunar/thunar-0.4.0rc1/thunar/thunar-properties-dialog.c:805: undefined reference to `thunar_file_is_desktop_file' Thunar-thunar-properties-dialog.o: In function `thunar_properties_dialog_icon_button_clicked': /home/ashura/Archive/deb/xfce/Thunar/thunar-0.4.0rc1/thunar/thunar-properties-dialog.c:702: undefined reference to `thunar_file_set_custom_icon' collect2: ld returned 1 exit status Do you have a solution for this or do I really have to get the SVN snapshot, make it compatible with my packaging system and possibly break existing patches? (As I don’t know how to modify the latter so that they work on modified sources.)
Ah. Yes, Debian should be somewhat behind. I'll just apply the patch and you'll have to wait for the debian maintainers to update. In the meantime, tho, you could merge the patch with your older version if you want.
> Ah. Yes, Debian should be somewhat behind. I'll just apply the patch and you'll have to wait for the debian maintainers to update. I’m fine with that, as this is no grave functionality. > In the meantime, tho, you could merge the patch with your older version if you want. You mean by manually editing the .c file, right? OK, I’ll try that. (The patch doesn’t seem that big.)
Committed with revision 23254. 2006-10-01 Benedikt Meurer <benny@xfce.org> * thunar/thunar-properties-dialog.c: Display the real mime type as tooltip for the "Kind" label. Bug #2369.
OK, the tooltip appears and shows the MIME type now. But instead of the normal filetype there is only a grey bar now. (Screenshot attached.)
Created attachment 813 Broken file type display in properties dialog
I guess you forgot to add the kind_label to the kind_ebox and show it.
> I guess you forgot to add the kind_label to the kind_ebox and show it. The problem was that I had let myself being confused with the one code block which appears several times. (Guess I just had to look at the line numbers more precisely.) Now the filetype and MIME type are being shown, but the background of the filetype is still as grey as in my screenshot. (It should be white instead.) Since the following line seems to be responsible for this („fill“ ...), is it really alright to remove it? gtk_table_attach (GTK_TABLE (table), dialog->kind_label, 1, 2, row, row + 1, GTK_EXPAND | GTK_FILL, GTK_FILL, 0, 3);
No, "fill" is about layouting, not style. The problem is with the event box. You need to make the event box' window input-only and above its children: gtk_event_box_set_above_child (GTK_EVENT_BOX (dialog->kind_ebox), TRUE); gtk_event_box_set_visible_window (GTK_EVENT_BOX (dialog->kind_ebox), FALSE);
> The problem is with the event box. You need to make the event box' window input-only and above its children: Great! Now everything works as I wished it to. Thanks for your quick help.
Seems like this has been lost with the 1.1.x line of Thunar. I’d be nice to see it implemented like before again.
This has indeed slipped into the GIO port. It is now fixed in master: commit 9180b7ad1a57c49b1e06a81cb337cf9a0a4f89ef Author: Jannis Pohlmann <jannis@xfce.org> Date: Fri Sep 3 12:13:48 2010 +0200 Display content type in the file properties dialog tooltip (bug #2369).
(In reply to comment #18) > This has indeed slipped into the GIO port. It is now fixed in master: Thanks. :-)