Right now, configure will fail if thunar-vfs is found but dbus is not. In this case, configure should succeed, but disable file/launcher icons. 1. Move the dbus check out of the condition, and change it to an optional depend. 2. Add a config.h #define for ENABLE_FILE_ICONS, which is set only if THUNAR_VFS_FOUND and DBUS_FOUND are both 'yes'.
Brian, if I understand this correctly, it will disable all desktop icons if dbus is not present, right? I know in beta2 the icons were available without dbus, and it seems that the changes associated with the new Trash icon are what actually need both dbus and thunar-vfs. Ultimately, it doesn't matter much to me, as I don't use the desktop icons anyway, but from a packaging standpoint, it's important to me. :)
No, no dbus will just disable file/launcher icons. Minimised app icons will still be there. I converted (or was in the process of converting) a bunch of non-trash stuff that just used dbus-send to use libdbus directly, hence the need for the dependency.
Ok, this should be fixed with rev 23236. From my commit message: ok, this should fix annoying build problems (bug 2344). here's how the dependencies work: no icons at all: * (no external deps beyond what's normal) minimised app icons: * exo (optional, for icon effects) file/launcher icons: * thunar-vfs * dbus * thunarx (optional, for thunar plugin support) * exo (optional, for icon effects) relevant build options: by default, the configure script will check for everything and enable everything if it's available. otherwise: --disable-desktop-icons: disables all desktop icons --disable-file-icons: disables file/launcher icons, but minimised app icons are still present --disable-exo: disables using exo for some icon effects (note: i believe thunar-vfs pulls in libexo anyway, so if file/launcher icons are enabled, there's really no reason to disable exo except maybe performance reasons) --disable-thunarx: disables using thunarx to load thunar plugins