The icon selection in the menueditor is not really convenient right now, esp. since one has to look up the name of the icon manually first. Since exo now contains an icon chooser dialog, it should be used in the menueditor if libexo is available. I'm going to attach a patch to do this for the edit dialog.
Created attachment 747 Possible fix This patch adds support for the icon to the edit dialog (should be easy to add to the add dialog...). If exo is not available when compiling xfdesktop it'll simply display the previous behaviour. The patch also removes the dialog separator, because we don't use it in Xfce's dialogs. Note that the patch adds a new translable string (-> "No icon"). But that shouldn't cause trouble as translators will have to check xfdesktop again before rc1 to translate the new desktop icon related strings.
great, your new icon chooser widget rox but i miss (or didn't find how) being able to select "no icon"
If its necessary to be able to reset the icon, you can add another button "Revert" (or whatever) to the dialog. But I don't think it makes sense to reset the icon for menu entries to "No icon".
The user should be able to remove a selected icon and set no icon instead. At least it's how the menueditor currently works and i don't want to remove that functionnality. I'll take a look into adding a button to the dialog then.
Add GTK_STOCK_REVERT, your-response-id, to exo_icon_chooser_dialog_new() and your-response-id to gtk_dialog_set_alternative_button_order(), between GTK_RESPONSE_ACCEPT and GTK_RESPONSE_CANCEL.
patch applied and i added support in the add dialog (rev 23095)