2165 – Check for xrender can be improved on solaris

Check for xrender can be improved on solaris

Status:

RESOLVED: FIXED

Priority:
Medium

Severity:
normal

Product:
Xfwm4

Component:

General

Comments

Description Neelakanth Nadgir 2006-08-14 15:49:03 CEST

The current configure script checks for xrender using "pkg-config xrender".
This does not work on a stock solaris install even though solaris supports 
xrender. A better way might be to search for a function within libXrender

Comment 1 Olivier Fourdan editbugs

2006-08-15 20:37:43 CEST

Humm, I wonder why Solaris doesn't ship the pkg config files for Xrender. BTW, I don't think replacing the pkg-config test with AC_CHECK_LIB() would be a good plan as pkg-config gives usefull informations about CFLAGS and LDFLAGS required to link with the lib.

The best would be to fallback to AC_CHECK_LIB() in case pkg-config returns no result, in case. 

I don't have access to a Solaris box, so a patch would be welcome ;)

Comment 2 Neelakanth Nadgir 2006-08-16 18:54:08 CEST

How about this..

bursar:/tmp/.../xfwm4-4.3.90.2 > diff configure.ac /tmp/configure.ac 
81a82,88
> else
>   dnl fallback to check for libXrender 
>   AC_CHECK_LIB([Xrender], [XRenderCreatePicture],
>       [ have_render="yes"
>         RENDER_LIBS=" -lXrender"
>         AC_DEFINE([HAVE_RENDER], [1], [Define to enable render])
>       ],[])

Comment 3 Olivier Fourdan editbugs

2006-08-16 18:56:52 CEST

If that works on Solaris, I'm fine with it.
Thanks.

Comment 4 Olivier Fourdan editbugs

2006-08-16 19:06:43 CEST

Applied on svn trunk.

Comments

Bug #2165

People

Version

Attachments

Additional information