User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.5) Gecko/20060727 Firefox/1.5.0.5 (Swiftfox) Build Identifier: rev 22562 Some fixes in xfrun4 Reproducible: Always Steps to Reproduce:
Created attachment 690 Patch * Addde g_type_class_add_private * Added NETK_APPLICATION_GET_PRIVATE definition * Added parent_class and finalize this one
Btw i think this also fixes the memory leak you were talking about Brain.
Gah, I always forget to chain up in _finalize()! Thanks for this; I can stop tearing out what little hair I have left. BTW, why are you calling the macro NETK_*? It's not a netk function... Anyway, since it's only called once, no need for a macro at all. Also, no need to _peek_parent(). The G_DEFINE_TYPE() macro already creates xfrun_dialog_parent_class and does that for you. Anyway... fixed.
(In reply to comment #3) > BTW, why are you calling the macro NETK_*? It's not a netk function... > Anyway, since it's only called once, no need for a macro at all. Because i copied the lines from netk_application... stupid me! (Patch from earlier this day). > > Also, no need to _peek_parent(). The G_DEFINE_TYPE() macro already creates > xfrun_dialog_parent_class and does that for you. MM didn't know that, thanks for the info.