User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.4) Gecko/20060602 Firefox/1.5.0.4 (Swiftfox) Build Identifier: Trunk Rev 22504 Xfdesktop crashes directly on startup, when it tries to run the style_set_cb function. Not every PC seems to have this problem, but it happend on my laptop. Reproducible: Always Steps to Reproduce:
Created attachment 669 Only update the background when really needed. This might even speed up startup a bit, because the function is called 2 times when you start xfdesktop.
That's not going to fix the crash, though. Can I get a backtrace? And the second patch band is unncessary.
Well it solved the problem here, tho. Anyway bt is attached.
Created attachment 670 Bracktrace 1
You fixed a symptom, not the cause... though the bt seems to show that gtk is setting the style before realising the window, which is kinda weird. Either way, your patch plus another check for GTK_WIDGET_REALIZED() should be sufficient.
Actually, it occurs to me that your patch is a bad idea. We *have* to set the back pixmap each time, regardless if the theme has actually changed or not, because whenever a style is applied that has its own back pixmap, it'll override ours. The crash should be fixed now though.
Yep, everything works fine now.