! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
menu editor tries to edit system wide menu
Status:
CLOSED: FIXED
Product:
Xfce4-menueditor
Component:
General

Comments

Description Jani Monoses 2006-05-28 19:16:22 CEST
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.3) Gecko/20060523 Ubuntu/dapper Firefox/1.5.0.3
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.3) Gecko/20060523 Ubuntu/dapper Firefox/1.5.0.3

when the menu editor is launched from the desktop menu's properties dialog it tries to edit the system wide menu in /etc/xdg and there are no permissions to do that.
If it is told to use a custom one it starts with a blank configuration.
It would be more useful if edit menu meant taking current menu, modifying it
and putting the result in the user's .config dir, in a transparent way as the panel does when the user tweaks the panel.


Reproducible: Always
Comment 1 Jean-François Wauthy editbugs 2006-06-04 18:27:46 CEST
it's the attended way, it does that since pre 4.2 release and it still should
Comment 2 Jani Monoses 2006-06-10 17:31:28 CEST
Found the problem. Indeed the expected way is what you describe, but the problem is here that the editor crashes on first run when creating the menu in ~/.config/ and leaves a 0 length file as menu.xml. Which is enough to override the system-wide one even if it is empty. This patch fixes it and indeed the behaviour is the nice one of copying the system wide menu over and working on that.


Index: menueditor/utils.c
===================================================================
--- menueditor/utils.c  (revision 22058)
+++ menueditor/utils.c  (working copy)
@@ -841,7 +841,7 @@
     if (strlen (*temp_set) > 0 && !g_strrstr (*temp_set, "span")) {
       text = g_markup_escape_text (*temp_set, strlen (*temp_set) * sizeof (gchar));
     }
-    (*temp_set)++;
+    temp_set++;
   }
   g_strfreev (set);

Comment 3 Jean-François Wauthy editbugs 2006-06-10 18:25:45 CEST
i definely have a problem with these double pointers

your patch has been committed with revision 22059

Bug #1863

Reported by:
Jani Monoses
Reported on: 2006-05-28
Last modified on: 2009-07-14

People

Assignee:
Xfce Bug Triage
CC List:
0 users

Version

Attachments

Additional information