User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.3) Gecko/20060513 Ubuntu/dapper Firefox/1.5.0.3 Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.3) Gecko/20060513 Ubuntu/dapper Firefox/1.5.0.3 make right click Open for unmounted (but mounted as well) volumes do the same thing as clicking on the remeovable icon would to (execute same function). Otherwise if not mounted it either does not do anything (no info) or it errors since there's no directory. Patch also contains a fix for removing from the removable_icons list otherwise I get warnings on pressing F5 because it tries to disconnects signals from invalid objects, like below. The patch may apply with a fuzz since I have some other changes in the same file. (xfdesktop:19393): GLib-GObject-WARNING **: invalid uninstantiatable type `(null)' in cast to `GObject' (xfdesktop:19393): GLib-GObject-WARNING **: instance of invalid non-instantiatable type `(null)' (xfdesktop:19393): GLib-GObject-CRITICAL **: g_signal_handlers_disconnect_matched: assertion `G_TYPE_CHECK_INSTANCE (instance)' failed (xfdesktop:19393): GLib-GObject-WARNING **: invalid uninstantiatable type `(null)' in cast to `GObject' (xfdesktop:19393): GLib-GObject-WARNING **: instance of invalid non-instantiatable type `(null)' (xfdesktop:19393): GLib-GObject-CRITICAL **: g_signal_handlers_disconnect_matched: assertion `G_TYPE_CHECK_INSTANCE (instance)' failed (xfdesktop:19393): GLib-GObject-WARNING **: invalid uninstantiatable type `(null)' in cast to `GObject' (xfdesktop:19393): GLib-GObject-CRITICAL **: g_object_set_data: assertion `G_IS_OBJECT (object)' failed Reproducible: Always
Created attachment 562 patch for two issues first hunk is for Open context menu item, second hunk the warning fix
Hehe, actually just now "fixed" the volume "Open" item thing myself after messing with the separators, but I like how you did it better with the conditional on the G_CALLBACK(). Thanks for the warning fix. Good catch - looks like that was a copy and paste error on my part. *sigh* Fixed, svn rev r21788