! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
user group permissions not handeled correctly
Status:
CLOSED: FIXED

Comments

Description Lari kukkonen 2006-05-22 23:00:01 CEST
Just tested this one svn version I pulled sec ago and dose same thing it did on beta1. Have only tested this one x86_64 but propably effects all platforms.

I have my storage and games arranged so that root is the owner and grouped to either video, music or games (depending on contents) groups that my main user is part of. Both group and owner has full rwx privilages, however thunar does not recognise the user goup and user being in group and those does not allow me to modify folder contents/files forcing me to ol' trusty terminal.

Viewing properties on any folder/file with this own/grp combination, permission tab shows root correctly as owner but group field is empty and all boxes are grayed out.
Comment 1 Benedikt Meurer editbugs 2006-05-23 07:13:36 CEST
That should be fixed in SVN. Did you make sure to terminate any instances of your beta1 Thunar first (Thunar -q) before testing SVN?
Comment 2 Lari kukkonen 2006-05-23 08:31:45 CEST
Used svn ebuild in fluidportage, it should remove old version. Just tryed manually pulling from svn to empty folder and buit it without installing but no change.
Comment 3 Benedikt Meurer editbugs 2006-05-23 08:40:54 CEST
Yes, but did you terminate any previously running instance? Hint: Thunar -q
Comment 4 Lari kukkonen 2006-05-23 09:01:45 CEST
OH, yes I did.
Comment 5 Benedikt Meurer editbugs 2006-07-09 21:23:33 CEST
Moving to 0.4.0rc1.
Comment 6 Michal Kurgan 2006-07-10 01:46:43 CEST
I can confirm that.
But thanks to You patches from http://bugzilla.xfce.org/show_bug.cgi?id=1670 all operations could be performed, only Permissions tab is grayed out.
 - from Thunar 0.3.2beta2
Comment 7 Benedikt Meurer editbugs 2006-07-30 22:35:08 CEST
The permissions tab of a file/folder, which you don't own are always grayed out, because you need to either own the file or be the superuser to change the permissions of a file/folder.
Comment 8 Michal Kurgan 2006-07-30 22:45:35 CEST
(In reply to comment #7)
> The permissions tab of a file/folder, which you don't own are always grayed
> out, because you need to either own the file or be the superuser to change the
> permissions of a file/folder.
> 

Yes, but the problem is that there are no correct entries there.
Owner is correct, but there is empty entry for group.
Comment 9 Benedikt Meurer editbugs 2006-07-30 22:47:38 CEST
Hm, is the group displayed in the detailed list view?
Comment 10 Michal Kurgan 2006-07-30 22:51:10 CEST
(In reply to comment #9)
> Hm, is the group displayed in the detailed list view?
> 

Yes, correct group is displayed there.
Also i can say that the group permission is the only on blank in Properties->Permissions tab, access rights are also as they should be.
Comment 11 Michal Kurgan 2006-07-30 22:57:33 CEST
One more comment.
In my case it is nicely shown in /var/spool directory.
Antoher thing i spoted there is that group is not missing in all cases ie. 
/var/spool/mail is missing group mail, but /var/spool/news has news group in grayed out combobox.
Difference between these directories is owner, news is owned by news user, but mail by root user.
Comment 12 Benedikt Meurer editbugs 2006-07-30 22:57:39 CEST
Created attachment 691 
Possible fix

Try this patch. It should solve the issue.
Comment 13 Michal Kurgan 2006-07-30 23:35:26 CEST
(In reply to comment #12)
> Created an attachment (id=691) [edit]
> Possible fix
> 
> Try this patch. It should solve the issue.
> 

No it doesn't work.
I think it could be a problem that is little up, in this function with call to function thunar_vfs_user_get_groups, this could limit group listing. Why here is such a limit?
Comment 14 Benedikt Meurer editbugs 2006-07-30 23:38:04 CEST
Because you can only change to a group that you are member of. BTW: Did you really restart Thunar after applying the patch (Thunar -q)? Because I was able to reproduce the problem here, and the patch fixes the issue for me.
Comment 15 Michal Kurgan 2006-07-30 23:57:28 CEST
(In reply to comment #14)
> Because you can only change to a group that you are member of. BTW: Did you
> really restart Thunar after applying the patch (Thunar -q)? Because I was able
> to reproduce the problem here, and the patch fixes the issue for me.
> 

Yes, sorry that was problem. Thunar wasn't restarted. Now this work as it suppose to work.
Thanks!

PS. May i suggest an small modification to http://thunar.xfce.org/pwiki/documentation/installation svn section? Just add this restart thingy there after make install.
Comment 16 Benedikt Meurer editbugs 2006-07-30 23:58:31 CEST
Well, it's a wiki. Feel free to update it. ;-)
Comment 17 Benedikt Meurer editbugs 2006-07-31 00:00:44 CEST
Committed with revision 22585.

2006-07-31	Benedikt Meurer <benny@xfce.org>

	* thunar/thunar-permissions-chooser.c
	  (thunar_permissions_chooser_file_changed): Make sure that the file's
	  group is included in the "Group" box. Bug #1838.

Bug #1838

Reported by:
Lari kukkonen
Reported on: 2006-05-22
Last modified on: 2009-07-17

People

Assignee:
Jannis Pohlmann
CC List:
1 user

Version

Version:
0.3.1svn

Attachments

Possible fix (685 bytes, patch)
2006-07-30 22:57 CEST , Benedikt Meurer
no flags

Additional information