! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
thunar_vfs_volume_mount does nt return true as documented
Status:
CLOSED: FIXED
Product:
Thunar-vfs
Component:
General

Comments

Description Jani Monoses 2006-05-22 08:57:22 CEST
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.3) Gecko/20060513 Ubuntu/dapper Firefox/1.5.0.3
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.3) Gecko/20060513 Ubuntu/dapper Firefox/1.5.0.3

The docstring says that the function returns true if mount succeeded or volume was already mounted.

For the hal-pmount case if the volume was mounted hal-pmount returns the error code 4. However the vfs function dtreats this as error from the exec function and thus returns FALSE.

A possible fix is that even on error check /proc/mount and if found return TRUE.


Reproducible: Always
Comment 1 Jani Monoses 2006-05-22 08:58:38 CEST
Created attachment 560 
patch

with this it returns true on subsequent invocations for a mounted volume.
Comment 2 Benedikt Meurer editbugs 2006-05-23 14:31:52 CEST
Created attachment 563 
Another idea

How about this one instead?
Comment 3 Jani Monoses 2006-05-23 14:56:25 CEST
yep, cleaner indeed. But let's hope gnome-mount does not have a similar quirk ;)
Comment 4 Benedikt Meurer editbugs 2006-05-23 15:02:51 CEST
I haven't received complaints from Fedora/RedHat users, so I guess it acts more like mount.
Comment 5 Benedikt Meurer editbugs 2006-05-23 15:11:49 CEST
Committed with revision 21799.

2006-05-23	Benedikt Meurer <benny@xfce.org>

	* thunar-vfs/thunar-vfs-volume-hal.c(thunar_vfs_volume_hal_mount):
	  pmount-hal returns an error if the volume is already mounted.
	  Bug #1833.

Bug #1833

Reported by:
Jani Monoses
Reported on: 2006-05-22
Last modified on: 2010-11-07

People

Assignee:
Jannis Pohlmann
CC List:
1 user

Version

Version:
unspecified

Attachments

patch (949 bytes, patch)
2006-05-22 08:58 CEST , Jani Monoses
no flags
Another idea (644 bytes, patch)
2006-05-23 14:31 CEST , Benedikt Meurer
no flags

Additional information