User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.0.3) Gecko/20060426 Firefox/1.5.0.3 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.0.3) Gecko/20060426 Firefox/1.5.0.3 The make command did not work correctly. Missing #include <gmodule.h> on line 44 of panel-plugins/mailwatch.c in xfce4-mailwatch-plugin-1.0.1.tar. The line is also missing in xfce4-mailwatch-plugin-1.0.0-2.fc4.src.rpm. Reproducible: Always Steps to Reproduce: 1. untar 2. ./configure 3. make Actual Results: The make command throws a syntax error. Expected Results: The application should compile cleanly. I am using Xfce version 4.2.3.2. Relevant lines from my make output: Making all in panel-plugin make[2]: Entering directory `/root/xfce4-mailwatch-plugin-1.0.1/panel-plugin' if /bin/sh ../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I. -I.. -pthread -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -DXTHREADS -D_REENTRANT -DXUSE_MTSAFE_API -I/usr/include/xfce4 -I/usr/X11R6/include -I/usr/include/libxml2 -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/include/freetype2/config -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/atk-1.0 -DXFCE_PANEL_LOCK\(\)=do{}while\(0\) -DXFCE_PANEL_UNLOCK\(\)=do{}while\(0\) -DDATADIR=\"/usr/local/share\" -DLOCALEDIR=\"/usr/local/share/locale\" -g -O2 -MT libmailwatch_la-mailwatch.lo -MD -MP -MF ".deps/libmailwatch_la-mailwatch.Tpo" -c -o libmailwatch_la-mailwatch.lo `test -f 'mailwatch.c' || echo './'`mailwatch.c; \ then mv -f ".deps/libmailwatch_la-mailwatch.Tpo" ".deps/libmailwatch_la-mailwatch.Plo"; else rm -f ".deps/libmailwatch_la-mailwatch.Tpo"; exit 1; fi gcc -DHAVE_CONFIG_H -I. -I. -I.. -pthread -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -DXTHREADS -D_REENTRANT -DXUSE_MTSAFE_API -I/usr/include/xfce4 -I/usr/X11R6/include -I/usr/include/libxml2 -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/include/freetype2/config -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/atk-1.0 "-DXFCE_PANEL_LOCK()=do{}while(0)" "-DXFCE_PANEL_UNLOCK()=do{}while(0)" -DDATADIR=\"/usr/local/share\" -DLOCALEDIR=\"/usr/local/share/locale\" -g -O2 -MT libmailwatch_la-mailwatch.lo -MD -MP -MF .deps/libmailwatch_la-mailwatch.Tpo -c mailwatch.c -fPIC -DPIC -o .libs/libmailwatch_la-mailwatch.o make[2]: Leaving directory `/root/xfce4-mailwatch-plugin-1.0.1/panel-plugin' make[1]: Leaving directory `/root/xfce4-mailwatch-plugin-1.0.1' mailwatch.c:1113: error: syntax error before "void" mailwatch.c:1114: error: syntax error before '*' token make[2]: *** [libmailwatch_la-mailwatch.lo] Error 1 make[1]: *** [all-recursive] Error 1 make: *** [all] Error 2
Created attachment 554 patch to add the gmodule.h to mailwatch.c
Committed, thanks.