Comment 1 Jasper Huijsmans 2006-05-19 19:35:53 CEST

Not sure where this report belongs, but not the panel, i would think. Perhaps the window manager could do something when no window has focus?

Comment 2 Olivier Fourdan 2006-05-20 07:38:59 CEST

Unfortunately, this is not possible. alt+f4 sends a WM_DELETE_WINDOW to the currertnyl focused window, and the panel is (should) not (be) focused by default, so it cannot receive the WM_DELETE_WINDOW message.

Comment 3 Olivier Fourdan 2006-05-20 07:46:55 CEST

Humm, lemme think about it though... Maybe I can do something.

Comment 4 Benedikt Meurer 2006-05-20 13:12:30 CEST

"If no other window is in the foreground" sounds like xfdesktop has the focus. So shouldn't this be handled by xfdesktop?

(In reply to comment #4)
> "If no other window is in the foreground" sounds like xfdesktop has the focus.
> So shouldn't this be handled by xfdesktop?

xfdesktop doesn't accept focus if desktop icons are disabled.  So... maybe not?

Comment 6 Benedikt Meurer 2006-05-20 20:00:45 CEST

Yep, but what happens if icons are enabled?

Nothing.  xfdesktop ignores WM_DELETE.

Comment 8 Benedikt Meurer 2006-05-20 20:09:01 CEST

That's what I mean... xfdesktop should probably tell xfce4-session to display the logout dialog.

Right... but isn't that confusing?  If desktop icons are enabled, it'll work, but not if they're disabled.

And I dislike having xfdesktop accept focus when icons are disabled, because there's zero point of having a focusable desktop, and it seems like it would be annoying.  Not that I'm totally attached to that behavior, so I don't mind changing it.

Comment 10 Benedikt Meurer 2006-05-20 20:17:18 CEST

I doubt that it'll confuse many people.

Comment 11 Olivier Fourdan 2006-05-20 21:02:17 CEST

Well, FYI it's been implemented in the window manager and it works since version 21727 commited earlier this morning, so I guess that bug should be considered as fixed.

Comment 12 Benedikt Meurer 2006-05-20 21:04:21 CEST

How does the window manager tell whether the ALT+F4 should be "send" to xfce4-session or to the focused application?

Comment 13 Olivier Fourdan 2006-05-20 21:14:35 CEST

> How does the window manager tell whether the ALT+F4 should be "send" to
> xfce4-session or to the focused application?

It calls session_logout () if no window is focused.

But indeed, the focus should return to the desktop if no other window can have it, so I fixed that too.

In the end, if xfdesktop is running, then it should call the session_logout() on WM_DELETE_WINDOW event too...

(In reply to comment #13)

> In the end, if xfdesktop is running, then it should call the session_logout()
> on WM_DELETE_WINDOW event too...
> 

But if it does that, then accidentally hitting alt+F4 when the desktop is focused (when the user thinks it's on some other window) will cause the session logout dialog to come up.  I really don't like that.

Comment 15 Benedikt Meurer 2006-05-20 21:29:33 CEST

Ehm, accidentally hitting alt+F4 is always bad, no matter if the desktop is focused.

Ok, implemented.  So this should be fixed then.