! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
seg faults when trying to delete certain file
Status:
CLOSED: FIXED
Severity:
critical

Comments

Description Aries-Belgium 2006-04-21 22:04:49 CEST
User-Agent:       Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.8.0.2) Gecko/20060308 Firefox/1.5.0.2
Build Identifier: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.8.0.2) Gecko/20060308 Firefox/1.5.0.2

I'm using Thunar 0.3.0 beta1 and when I try to delete this file:
%5BFrom%20www.metacafe.com%5D%20110627.561623.8.wmv (3.5 mb)

I get a Segmentation fault.

I haven't got this with any other file.

Reproducible: Always

Steps to Reproduce:
1. Open Thunar
2. Browser to /tmp
3. Select the file
4. Press Delete on keyboard

Actual Results:  
Segmentation fault

Expected Results:  
That the dialog for canceling or deleting the file shows up
Comment 1 Aries-Belgium 2006-04-22 05:16:45 CEST
I checked my dmesg and this is what I get after the seg fault, maybe this is more usefull to you:

Thunar[13625]: segfault at 00007ffffe773de8 rip 00002aaaad7e642d rsp 00007ffffe773df0 error 6
Comment 2 Benedikt Meurer editbugs 2006-04-22 14:27:32 CEST
Can you run Thunar in gdb (see http://gaim.sourceforge.net/gdb.php) and attach a backtrace?
Comment 3 Aries-Belgium 2006-04-22 18:41:13 CEST
Created attachment 518 
gdb backtrace after segfault

This is what I get from gdb when I type bt after the segfault.
I hope it's of any value for you ...
Comment 4 Benedikt Meurer editbugs 2006-04-23 13:06:53 CEST
Created attachment 519 
Suggested fix

Yep, that helped. Please try this patch.
Comment 5 Aries-Belgium 2006-04-23 16:54:34 CEST
(In reply to comment #4)
> Created an attachment (id=519) [edit]
> Suggested fix
> 
> Yep, that helped. Please try this patch.
> 

That worked perfectly.
Comment 6 Benedikt Meurer editbugs 2006-04-23 17:23:25 CEST
Committed with revision 21186.

2006-04-23	Benedikt Meurer <benny@xfce.org>

	* thunar/thunar-launcher.c, thunar/thunar-permissions-chooser.c,
	  thunar/thunar-standard-view.c: Use indirect string passing for
	  gtk_message_dialog_new() in case the strings (i.e. filenames)
	  contain printf() parameter specifications. Bug #1704.

Comment 7 Benedikt Meurer editbugs 2006-06-14 17:34:02 CEST
*** Bug 1924 has been marked as a duplicate of this bug. ***

Bug #1704

Reported by:
Aries-Belgium
Reported on: 2006-04-21
Last modified on: 2009-07-17
Duplicates (1):
  • 1924 Deleting A Single file with a '%' character.

People

Assignee:
Jannis Pohlmann
CC List:
1 user

Version

Version:
0.3.0beta1

Attachments

gdb backtrace after segfault (3.60 KB, text/plain)
2006-04-22 18:41 CEST , Aries-Belgium
no flags
Suggested fix (2.35 KB, patch)
2006-04-23 13:06 CEST , Benedikt Meurer
no flags

Additional information