! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Correct data type for the request handle
Status:
RESOLVED: FIXED
Product:
Tumbler
Component:
General

Comments

Description Markus Elfring 2020-05-12 18:30:27 CEST
The thumbnail management DBus specification contains information for the interface “Request the creation of thumbnails”.
The D-Bus data type “u” (Unsigned 32-bit integer) is specified for the argument “handle” of the method “Queue”.
https://wiki.gnome.org/DraftSpecs/ThumbnailerSpec#Request_the_creation_of_thumbnails

But the data type “guint” (or “gint”) is used so far by variables of the service implementation.
https://gitlab.xfce.org/xfce/tumbler/-/blob/f5589df90ce5b88c94b921a0989e41b09e208286/tumblerd/tumbler-scheduler.h#L92

Thus I (and “afdw”) suggest to use the data type “guint32” instead in a consistent way.
https://gitlab.xfce.org/xfce/tumbler/-/merge_requests/1#note_2070
Comment 1 Markus Elfring 2020-05-16 12:56:51 CEST
Created attachment 9867 
Update suggestion for using the data type “guint32” instead of “guint” at some source code places
Comment 2 Git Bot editbugs 2020-05-17 19:51:32 CEST
Ali Abdallah referenced this bugreport in commit 4a25646920b4a3703e9aa5a09bae16e148b8ee51

Use guint32 for request handle

https://gitlab.xfce.org/xfce/tumbler/commit/4a25646920b4a3703e9aa5a09bae16e148b8ee51

Bug #16833

Reported by:
Markus Elfring
Reported on: 2020-05-12
Last modified on: 2020-05-17

People

Assignee:
Ali Abdallah
CC List:
0 users

Version

Attachments

Additional information