Repeated rename via bulk renamer only works when it is launched via console: gdb --args /thunar/.libs/thunar -B In order to trigger the crash, add two files to the bulk renamer and rename then. Than rename then again. The way of renaming (numbering, date, etc.) does not matter. I can reproduce the bug on master, and on 1.8.0, so it is not related to recent commits. I got the following Error/Backtrace : thunar:ERROR:thunar-renamer-progress.c:262:thunar_renamer_progress_next_idle: assertion failed: (g_list_length (renamer_progress->pairs_done) == renamer_progress->n_pairs_done) Bail out! thunar:ERROR:thunar-renamer-progress.c:262:thunar_renamer_progress_next_idle: assertion failed: (g_list_length (renamer_progress->pairs_done) == renamer_progress->n_pairs_done) Thread 1 "thunar" received signal SIGABRT, Aborted. __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50 50 ../sysdeps/unix/sysv/linux/raise.c: Datei oder Verzeichnis nicht gefunden. (gdb) bt #0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50 #1 0x00007ffff696355b in __GI_abort () at abort.c:79 #2 0x00007ffff6b40de3 in () at /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0 #3 0x00007ffff6b9c77b in g_assertion_message_expr () at /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0 #4 0x00005555555df748 in thunar_renamer_progress_next_idle (user_data=<optimized out>) at thunar-renamer-progress.c:262 #5 0x00007ffff6b744de in g_main_context_dispatch () at /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0 #6 0x00007ffff6b74890 in () at /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0 #7 0x00007ffff6b74b63 in g_main_loop_run () at /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0 #8 0x00005555555dfb81 in thunar_renamer_progress_run (renamer_progress=0x555555f3f9c0, pairs=0x5555558da240 = {...}) at thunar-renamer-progress.c:376 #9 0x00005555555dc452 in thunar_renamer_dialog_response (dialog=0x55555592a300, response=<optimized out>) at thunar-renamer-dialog.c:804 #10 0x00007ffff6c6118e in g_cclosure_marshal_VOID__BOOLEANv () at /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0 #11 0x00007ffff6c5f206 in () at /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0 #12 0x00007ffff6c7d8d4 in g_signal_emit_valist () at /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0 .... I dumped the reimaining backtrace ... only alot of internal g_signal stuff and the main / g_application_run
May i will fixed this bug?
(In reply to Dmitry Ovcharov from comment #1) > May i will fixed this bug? Please go for it, if you can. Patches are welcome !
I can't reproduce this bug neither thunar built from xfce-4.14 branch nor Thunar 1.8.9 (Xfce 4.14) from my distro(Mint XFCE).
Hmm, strange, I can reliably reproduce it. Suficcient if I create a file "1" in the home folder. Note that you need to launch the bulk renamer with "thunar -B" to reproduce, and make sure there is no running thunar instance left: thunar -q;thunar/.libs/thunar -B
I tried to reproduce this crash, but no success. Thunar 1.8.14 GLib 2.64.2
Sure, i ran it from command line with -B option, according the repro steps. I is looks like it environment depended issue.
> and make sure there is no running thunar instance left: > thunar -q;thunar/.libs/thunar -B I will try reproduce bug today with "-q" before running with files in home directory.
Created attachment 9857 patch My bad. The version installed by the distribution does not include assertion code lines, so it will not crash.
Theo Linkspfeifer referenced this bugreport in commit 5faa5ef29b74ce7c8b96be49f6930f3705717645 Fix crash in bulk renamer on repeated rename (Bug #16824) https://gitlab.xfce.org/xfce/thunar/commit/5faa5ef29b74ce7c8b96be49f6930f3705717645
Theo Linkspfeifer referenced this bugreport in commit efa3b55d968ab18235d1160e25b4ebd2d2fcf18b Fix crash in bulk renamer on repeated rename (Bug #16824) https://gitlab.xfce.org/xfce/thunar/commit/efa3b55d968ab18235d1160e25b4ebd2d2fcf18b
(In reply to Theo Linkspfeifer from comment #8) > Created attachment 9857 > patch Thanks alot for the fix Theo, works fine now for me ! Pushed to 4.14 and master, to be released in thunar 1.8.15 and 1.9.0 @Dmitry Ovcharov As well thanks for taking a try on it ! .. next time best pick some bug, and dont let Theo know about it :P