! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Update dialogs for libxfce4ui 4.15.1 XfceTitledDialog new API
Status:
RESOLVED: FIXED

Comments

Description Andre Miranda editbugs 2020-03-31 03:59:07 CEST
Created attachment 9660 
dialog.diff

Starting with libxfce4ui 4.15.1, users of XfceTitledDialog (now using CSD) have to apply very small changes, but without them buttons will end in the header bar.
I'm considering to apply the attached patch on master and 4.14 branches.
Comment 1 Simon Steinbeiss editbugs 2020-03-31 07:23:17 CEST
Fyi, there is also xfce_titled_dialog_add_action_widget (as an equivalent to gtk_dialog_add_action_widget).

Tried to summarize that in my blog post ;)

Other than that I see little harm in applying such a patch also to the 4.14 branch.
Comment 2 alexxcons editbugs 2020-03-31 08:52:43 CEST
Looks good to me !

Yes, I guess "xfce_titled_dialog_add_action_widget " would be even better to only have a single line in the #if / #else

Ok for me to have it as well on the 4.14 branch, in case xfce4ui 4.16. will be released before thunar 1.10.
Comment 3 Git Bot editbugs 2020-04-03 03:10:52 CEST
Andre Miranda referenced this bugreport in commit 2d1bbe5737677a268c4badb8955d20e0639f7d23

Support libxfce4ui XfceTitledDialog new API (Bug #16616)

https://git.xfce.org/xfce/thunar/commit?id=2d1bbe5737677a268c4badb8955d20e0639f7d23
Comment 4 Git Bot editbugs 2020-04-03 03:11:39 CEST
Andre Miranda referenced this bugreport in commit 2a3db233bf6242d280c02e065c343c0195829556

Support libxfce4ui XfceTitledDialog new API (Bug #16616)

https://git.xfce.org/xfce/thunar/commit?id=2a3db233bf6242d280c02e065c343c0195829556
Comment 5 Andre Miranda editbugs 2020-04-03 03:15:19 CEST
Thanks for the suggestions!

Bug #16616

Reported by:
Andre Miranda
Reported on: 2020-03-31
Last modified on: 2020-04-03

People

Assignee:
Xfce Bug Triage
CC List:
2 users

Version

Attachments

dialog.diff (1.59 KB, patch)
2020-03-31 03:59 CEST , Andre Miranda
no flags

Additional information