Created attachment 9524 
patch

Comment 2 alexxcons 2020-03-03 22:43:02 CET

Thanks for the patch !

How does that work / who will trigger these Desktop actions ?

Will that result in entries in the menu when the .desktop file is right-clicked ?

Comment 3 Simon Steinbeiss 2020-03-03 23:05:34 CET

Desktop action support shall land in the panel's launcher plugin, so right-clicking a launcher would expose them.
In general desktop action support can more easily be added to other components' context menus with the new garcon method I added:
https://git.xfce.org/xfce/garcon/commit/?id=05e54ee6567374d0b07880b2b635254f51190f94

(In reply to alexxcons from comment #2)
> How does that work / who will trigger these Desktop actions ?

Already functional in whisker menu when you right click on an entry like Firefox. You'll find entries for 'Open in New Window' and 'Open in New Private Window'

Comment 5 Theo Linkspfeifer 2020-03-04 18:14:25 CET

Will those entries be translated?

Yes

Created attachment 9537 
patch suitable for name translations

Comment 8 alexxcons 2020-03-07 00:37:57 CET

(In reply to Jay Philips from comment #4)
> (In reply to alexxcons from comment #2)
> > How does that work / who will trigger these Desktop actions ?
> 
> Already functional in whisker menu when you right click on an entry like
> Firefox. You'll find entries for 'Open in New Window' and 'Open in New
> Private Window'

Just took a try for whisker menu master .. looks like I miss something: https://imgur.com/ttwkErG.png

However if you can confirm that the thunar patch works for you, I would push it.

Created attachment 9544 
final patch

(In reply to alexxcons from comment #8)
> However if you can confirm that the thunar patch works for you, I would push
> it.

Forgot one line. The patch will work when its built with translations.

Comment 10 Git Bot 2020-03-08 00:48:17 CET

Yousuf Philips referenced this bugreport in commit 3d14b834dfe6b9eac1679b41352d1585f034ef1c

Add desktop actions for home, computer and trash (bug #16497)

https://git.xfce.org/xfce/thunar/commit?id=3d14b834dfe6b9eac1679b41352d1585f034ef1c

Comment 11 alexxcons 2020-03-08 00:49:10 CET

ok, pushed it to master now.

Thanks for the patch !