The function I liked was removed as a bug. IMO the fix is not necessary as the result of this fix can be achieve by select a solid white color. Bug #10887 removes a nice feature as overlaying a scaled image over a stretched image allows a high quality background for images that close quality and/or are distorted by stretching. Bug #10887 removes a nice feature and add no functionality as the same result can be achieved as noted above. Components installed: libxfce4menu-4.14.1 libxfce4util-4.14.0 xfce-4.14 xfce4-appfinder-4.14.0 xfce4-clipman-plugin-1.4.3_2 xfce4-conf-4.14.1 xfce4-desktop-4.14.1 xfce4-notifyd-0.4.4_1 xfce4-panel-4.14.1 xfce4-screenshooter-plugin-1.9.7 xfce4-session-4.14.0_1 xfce4-settings-4.14.1 xfce4-terminal-0.8.9.1 xfce4-tumbler-0.2.8 xfce4-wm-4.14.0_1
https://git.xfce.org/xfce/xfdesktop/commit/src/xfce-backdrop.c?id=caaaddf07bc3235462572cb408ce3bb607f5b880 - GdkColor c = { 0, 0xffff, 0xffff, 0xffff }; - final_image = create_solid(&c, w, h, TRUE, 0x00); + GdkRGBA c = { 1.0f, 1.0f, 1.0f, 1.0f }; + final_image = create_solid(&c, w, h); The alpha value was changed from 0.0 to 1.0, maybe by mistake.
Can you guys please add steps of how to reproduce the bug? Thanks.
I can supply a screen shot if required it this is pretty easy to duplicate. Prior to the change if you selected a background image with options: color: transparent; style: scaled and that did not fill the screen; you could then select style stretched and then style: scaled and get a potentially nice background image that filled the screen and was less pixelated. zoom and centered similarily could work and produce a better resullt. Someone deemed this behavior a bug so that stretched always appears with a white border. It is my contention that this 'fix' was available under the old code. Just choose color: white and style: scaled. I can provide a graphic if I did not manage to explain it
Yes, please provide screenshots and a list of steps with actual and expected results.
Three screen shots added. Note I do not have gimp installed so I can not produce the old result. I think these three images make it clear what has changed: 1) https://www.safeport.com/stretched 2) https://www.safeport.com/scaled_white 3) https://www.safeport.com/scaled_transparent 1) image is stretched to fill the screen. As you can see this is a high quality image that only needs to be stretched horizontally to fill the screen. With this image there is some distortion. If really required I can provide an image where the distortion is not acceptable. 2) Here we have solid white and scaled. Again no gimp You can see the white boarders by the width of the task bar. This is not very hard to reproduce just pick an image that will not fill your monitors screen 3) Here we have transparent and scaled. This is the same result as #2. So my first point was/is the fixed provides no new function, it merely removes something that was useful, at least in my opinion. Comparing #2 to #3 you can see the distortion in the image. In the old behavior If I first did stretched+transparent and followed that with scaled+transparent the current image overlays the previous image. This has the effect of coloring in the white boarders with the right and left parts of the stretched background. In my case I have a lot of images that worked fine on my 17" (am smaller) monitors but are totally unacceptable on my 22" (and larger) monitors. On the theory that the purpose of the background function is to provide a cool looking desktop of the user's choice, the old code is much better. My second point was for people that prefer the current version, they can have that by using scaled with a solid white background. So the "fix" provides nothing new, it just removes some options in what images can be used for a background.
Created attachment 9467 patch Based on my previous comment I wrote this patch.
https://bugzilla.xfce.org/show_bug.cgi?id=16380 alexxcons <alexxcons@xfce.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexxcons@xfce.org Might as well remove the transparent option. As I understand the email it effectively does that
Theo Linkspfeifer referenced this bugreport in commit ba3d36de92adc52dbe76a9824e89af462f46c8b8 Fix transparent background color (Bug #16380) https://git.xfce.org/xfce/xfdesktop/commit?id=ba3d36de92adc52dbe76a9824e89af462f46c8b8
Theo Linkspfeifer referenced this bugreport in commit 47147df8f1ff7dbec033b05968692d83756d0f44 Fix transparent background color (Bug #16380) https://git.xfce.org/xfce/xfdesktop/commit?id=47147df8f1ff7dbec033b05968692d83756d0f44
After some IRC discussion with Theo, and some testing, I think it will not hurt to just bring back the old behaviour. So I pushed the patch to master and 4.14 branch .. to be released in 4.14.3 (In reply to Doug Denault from comment #7) > Might as well remove the transparent option. As I understand the email it > effectively does that Yes, it looks like the only reason to have "color: transparent" is, to have the mentioned effect. Another option would have been to just remove the option to select "transparent". Thank you both for taking care !