! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Shift+drag and ctrl-drag should behave the same in xfdesktop and thunar
Status:
RESOLVED: MOVED
Product:
Xfdesktop
Component:
General

Comments

Description alexxcons editbugs 2019-12-30 21:42:33 CET
Triggered by Bug #7526

It seems to be common sense among file manager to invert the selection on "ctrl-drag", so I think it would make sense to have the same for xfdesktop.
(currently on xfdesktop ctrl-drag adds to the selection)

In thunar 1.6.x shift+drag was used to "add to selection" .. thats a regression in thunar 1.8.x which should be fixed (detailes in bug #7526)
Currently xfdesktop just opens a context menu on shift + "leftmouse". Shift+drag so far is not supported. It would be nice to add support for it.
Comment 1 Theo Linkspfeifer editbugs 2020-01-01 14:34:46 CET
Created attachment 9345 
quick diff

This diff adds the desired behavior while also removing shift + click as right-click alternative.
Comment 2 alexxcons editbugs 2020-01-01 22:13:20 CET
(In reply to Theo Linkspfeifer from comment #1)
> Created attachment 9345 
> quick diff
> 
> This diff adds the desired behavior while also removing shift + click as
> right-click alternative.

Wow, nice !

Works already very good for me, just from time to time the inversion does not work.
Seems to be related to truncation of the label text.

If I have to starters with label "test1" and "test2", there is no problem. But as soon as I extend the name to e.g.g "test1test1test1" and "test2test2test2", I can reproduce the bug.
Comment 3 Theo Linkspfeifer editbugs 2020-01-07 11:52:54 CET
Yes, I can confirm that glitch.
Comment 4 Git Bot editbugs 2020-05-26 00:34:05 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/xfdesktop/-/issues/55.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #16321

Reported by:
alexxcons
Reported on: 2019-12-30
Last modified on: 2020-05-26

People

Assignee:
Xfce Bug Triage
CC List:
3 users

Version

Version:
Unspecified

Attachments

quick diff (6.15 KB, patch)
2020-01-01 14:34 CET , Theo Linkspfeifer
no flags

Additional information