! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Use libxfce4ui instead of custom solutions
Status:
RESOLVED: MOVED
Product:
Xfce4-panel-profiles
Component:
General

Comments

Description ema-pe 2019-11-30 18:07:22 CET
Created attachment 9286 
Commits that integrate libxfce4ui in xfce4-panel-profiles

Hi,

I've integrated libxfce4ui's help dialog and XfceTitledDialog in xfce4-panel-profiles, instead using custom solutions. I attached the patch (two commits, one for help dialog and one for XfceTitledDialog) and two screenshots with that shows the effects on these commits.
Comment 1 ema-pe 2019-11-30 18:08:14 CET
Created attachment 9287 
Screenshot of the new help dialog
Comment 2 ema-pe 2019-11-30 18:09:56 CET
Created attachment 9288 
Screenshot of XfceTitleDialog implemented
Comment 3 ema-pe 2019-11-30 18:12:42 CET
Only a note: I'm learning GTK+/Glade and so on, so my implementation maybe not the best or it may doesn't follow standard guidelines.
Comment 4 Sean Davis editbugs 2019-12-19 03:09:23 CET
This patch seems like it should work, but I am hesitant to apply it since various distros (including Debian and Ubuntu) aren't shipping with libxfce4ui introspection enabled.
Comment 5 ema-pe 2019-12-19 10:34:27 CET
Hi, why are they not shipping libxfce4ui with introspection enabled? On Fedora is enabled by default. Can't we ask to Debian and Ubuntu maintainers to enable it?
Comment 6 Git Bot editbugs 2020-05-24 20:35:49 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/apps/xfce4-panel-profiles/-/issues/4.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #16231

Reported by:
ema-pe
Reported on: 2019-11-30
Last modified on: 2020-05-24

People

Assignee:
Sean Davis
CC List:
1 user

Version

Version:
unspecified

Attachments

Additional information