! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[regression] Removing files is slower in 4.14
Status:
RESOLVED: FIXED

Comments

Description Marcin Kocur 2019-11-03 15:30:53 CET
Today I upgraded thunar (1.6.15-1 -> 1.8.9-2)

Now to reproduce

1. Clone some middle-sized git repository, example: git clone https://github.com/daniruiz/flat-remix-gtk.git
2. Open the repository in thunar
3. ctrl+a and shft+delete

You will notice that in Xfce 4.14 (compared to 4.12) the dialog with removing files actually shows what is being removed. It's more accurate, it's true. However, removal process takes forever, compared to xfce 4.12 or rm -rf. I think that the previous inaccurate progress bar was much better because you wouldn't wait anyway. I'm using SSD disc.
Comment 1 Git Bot editbugs 2019-11-03 17:38:34 CET
Andre Miranda referenced this bugreport in commit d82652eb1dd78cf3e78836dcd7100a25b02dbba3

thunar-job: callee should keep track of the number of processed files (Bug #16117)

https://git.xfce.org/xfce/thunar/commit?id=d82652eb1dd78cf3e78836dcd7100a25b02dbba3
Comment 2 Andre Miranda editbugs 2019-11-03 17:40:33 CET
Using shift+delete on the clone repository:

thunar 1.8.9: ~35 seconds
thunar 1.6.11: ~20 seconds
nautilus: ~25 seconds
nemo: instantly
thunar master: ~20 seconds

Please let know if it works well before cherry picking this fix to thunar 1.8.x.
Comment 3 Marcin Kocur 2019-11-03 19:22:38 CET
1.8.9 - 28s
1.6.15 - 15s
d82652eb - 15s

Thanks! I'm really thrilled that I can just report a bug and it gets fixed so fast :)
Comment 4 Git Bot editbugs 2019-11-03 23:57:28 CET
Andre Miranda referenced this bugreport in commit 00188732fc51aa40c29a4a13ff29b1a930a4d124

thunar-job: callee should keep track of the number of processed files (Bug #16117)

https://git.xfce.org/xfce/thunar/commit?id=00188732fc51aa40c29a4a13ff29b1a930a4d124
Comment 5 Andre Miranda editbugs 2019-11-04 00:02:02 CET
(In reply to Marcin Kocur from comment #3)
> Thanks! I'm really thrilled that I can just report a bug and it gets fixed
> so fast :)

You're welcome, at the same time you're also lucky that I had free time and got interested by this problem, don't expect this to happen too often :)

Bug #16117

Reported by:
Marcin Kocur
Reported on: 2019-11-03
Last modified on: 2019-11-04

People

Assignee:
Xfce Bug Triage
CC List:
1 user

Version

Attachments

Additional information