! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[PATCH] make window layout settings work correctly
Status:
RESOLVED: FIXED
Priority:
Medium
Severity:
normal
Product:
Catfish
Component:
General

Comments

Description Maurizio Galli 2019-10-24 09:12:36 CEST 
Created attachment 9148 
Fix window layout setting switch

catfish.rc needs the line use-headerbar': False or use-headerbar': True for the setting to switch appearance to work correctly.

Because CatfishSettings.py sets the string to None, changing the appearance in Catfish settings does not work.

The attached patch fixes the issue, with the downside of having CSD on by default.
Comment 1 Git Bot editbugs 2019-11-15 22:33:00 CET 
Sean Davis referenced this bugreport in commit 10d33338302638425d48cd124e15b2a179d14458

Fix initializing Catfish layout settings (bug #16085)

https://git.xfce.org/apps/catfish/commit?id=10d33338302638425d48cd124e15b2a179d14458
Comment 2 Sean Davis editbugs 2019-11-15 22:33:42 CET 
The above patch should fix the issue, without any consequences. The issue was basically that the setting could not be initialized.
Comment 3 Sean Davis editbugs 2019-12-19 11:53:28 CET 
*** Bug 16220 has been marked as a duplicate of this bug. ***

Bug #16085

Reported by:
Maurizio Galli
Reported on: 2019-10-24
Last modified on: 2019-12-19
Duplicates (1):

People

Assignee:
Sean Davis
CC List:
1 user

Version

Version:
unspecified
Target Milestone:
---

Attachments

Fix window layout setting switch (800 bytes, patch)
2019-10-24 09:12 CEST , Maurizio Galli 		no flags

Additional information