! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Folder size infinitive loop due to symlinks
Status:
CLOSED: FIXED

Comments

Description Harold Aling 2006-03-25 00:02:04 CET
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.1) Gecko/20060321 Firefox/1.5.0.1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.1) Gecko/20060321 Firefox/1.5.0.1

The folder size feature follows symlinks in it's calculation. Following a symlink up in the tree will recount that folder inifinitivly...

Reproducible: Always

Steps to Reproduce:
1.Create and open a test folder: mkdir test && cd test
2.ln -s .. symlink
3.check the properties of the test folder in Thunar and the counter will start running...
Comment 1 Benedikt Meurer editbugs 2006-03-25 00:48:06 CET
Created attachment 484 
Suggested fix

Can you try this patch?
Comment 2 Harold Aling 2006-03-25 01:17:54 CET
Sorry, the patch didn't fix it.

Isn't it better to 'just not follow' symlinks just like 'du -hs'?
Comment 3 Benedikt Meurer editbugs 2006-03-25 16:08:02 CET
Fixed with revision 20544.

2006-03-25	Benedikt Meurer <benny@xfce.org>

	* thunar-vfs/thunar-vfs-deep-count-job.{c,h},
	  thunar-vfs/thunar-vfs-types.h, thunar-vfs/thunar-vfs.{c,h},
	  thunar-vfs/thunar-vfs.symbols: Allow caller to specify whether the
	  ThunarVfsDeepCountJob should follow symlinks to folders. Bug #1606.
	* thunar/thunar-size-label.c(thunar_size_label_file_changed): Do not
	  follow symlinks when calculating the size of folders. Bug #1606.

Comment 4 Harold Aling 2006-03-26 11:53:25 CEST
Confirmed... Thanx!

Bug #1606

Reported by:
Harold Aling
Reported on: 2006-03-25
Last modified on: 2009-07-17

People

Assignee:
Jannis Pohlmann
CC List:
0 users

Version

Version:
unspecified

Attachments

Suggested fix (4.97 KB, patch)
2006-03-25 00:48 CET , Benedikt Meurer
no flags

Additional information