! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Fix fullscreen hotkey handling
Status:
RESOLVED: FIXED
Priority:
Medium
Severity:
normal
Product:
Parole
Component:
General

Comments

Description Markus Ongyerth 2019-10-02 21:10:45 CEST 
Created attachment 9067 
A patch to fix the issue

We found out, that parole will not honor the Volume Up/Down or Mute-Toggle don't work when the player is set into fullscreen.

We fixed that by re-working the way keys are actually handled in Parole (went from the glade embedded handler to code). 


I'm upstreaming a couple of patches while traveling, so this might also be done by https://git.xfce.org/apps/parole/commit/?h=bluesabre/gtk3&id=319707d65b26d960916a68226b28f351035724a9 but I can't test right now
Comment 1 Git Bot editbugs 2019-10-02 23:26:34 CEST 
Markus Ongyerth referenced this bugreport in commit 18bbdccbc36863273db8042dc18a079bc0208795

Fix volume hotkeys in fullscreen (Bug #16005)

https://git.xfce.org/apps/parole/commit?id=18bbdccbc36863273db8042dc18a079bc0208795
Comment 2 Simon Steinbeiss editbugs 2019-10-02 23:26:56 CEST 
Not sure why it didn't work the glade way, but thanks for the fix!

Bug #16005

Reported by:
Markus Ongyerth
Reported on: 2019-10-02
Last modified on: 2019-10-02

People

Assignee:
Simon Steinbeiss
CC List:
1 user

Version

Version:
1.0.4
Target Milestone:
1.0

Attachments

A patch to fix the issue (2.65 KB, patch)
2019-10-02 21:10 CEST , Markus Ongyerth 		no flags

Additional information